Repository navigation
fix(uipath-maestro-case): one entryWhen call per SDD rule row, array means AND - #5013
Open
rockymadden wants to merge 2 commits into
Open
rockymadden wants to merge 2 commits into
rockymadden wants to merge 2 commits into
Conversation
…means AND Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
rockymadden
requested review from
a team,
dmetzgar and
tmatup
as code owners
November 19, 2026 20:38
Contributor
|
Claude finished @rockymadden's task in 53s —— View job SummaryAdds one paragraph and a two-line example after the minimal shape in Change-by-Change Review1.
|
| Area | Status | Notes |
|---|---|---|
| Frontmatter | OK | Untouched |
| E2E Tests | OK | No new capability; evals cited. An optional smoke task is suggested above |
| Skill Body | OK | Low: stage/task name ambiguity at line 108 |
| References & Assets | OK | No links added; no duplication with references/case-runtime.md |
| Repo Hygiene | OK | Scoped to one skill; no secrets or paths; flavor markers untouched |
Issues for Manual Review
- Check with the builder-sdk owners that
rule('selected-stage-exited', { stage, expression })is the exact rule id and option name. The skill defers rule signatures todist/api-members.md, so I couldn't confirm them from this repo. - The claim that "
case-enteredholds only at case start" is runtime semantics. It matches the eval evidence in the PR body, but it's worth confirming with the Maestro runtime owners.
Conclusion
Approve. A small, accurate fix for an expensive mistake that agents actually made. The 'Manager Approval' stage name is the only thing I'd change before merge, and it's optional.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
One paragraph and a two-line example in
skills/uipath-maestro-case/SKILL.md, after the minimal shape: an array in oneentryWhen/exitWhen/completeWhencall ANDs its rules, each call is another OR condition, so each SDD Entry/Exit Rule row gets its own call and a row's IF expression is that rule'sexpression.The studioweb flavor inherits it (the text sits outside every
skill-flavorblock; the flavor overrides nothing near it).Why
Live coder evals of #4903 (round 8), Studio Web
e2e_expense_runnable: the SDD stage had two entry rows ("case entered", "Manager Approval exited with Return"). The agent wrote.entryWhen([rule('case-entered'), rule('selected-stage-exited', { ..., expression })]). It compiled to one entry condition, AND(CaseEntered, StagesExited and expr). The stage could never be entered, and the case sat attrigger_1for 580 s.contract_execution"Return for corrections" made the same mistake (two rules ANDed where the SDD row is one rule with an IF expression). The claude-code run wrote separate calls and passed.validate --strictaccepts both shapes.Builder SDK semantics, from
typescript/sdk/src/case/case-sdk.ts(ruleGroups): one rule or an array is one AND-group, a nested array is an OR-of-AND grid, each call pushes another condition. The SDK is correct and documented; the skill never said it.Testing
npm run skills:validate,skills:build,skills:check-links: pass. Built default and studioweb trees both contain the paragraph.node --test tests/scripts/studioweb-flavor-contract.test.mjs tests/scripts/compose-skill-flavor.test.mjs: 91 pass.e2e_expense_runnable,contract_execution), studio-web and claude-code harness: see comment.Not verified
SKILL.md: it conflicts withmainalready (stale base), not because of this change.Follow-up
builder-sdk
checklint for an AND-group that mixescase-enteredwith a rule on a later event (cannot fire), next to the rules incheck-rule-semantics.ts.🤖 Generated with Claude Code