Skip to content

🍒 [v1.207] fix(uipath-maestro-bpmn): tidy a process built into the Studio Web template - #5002

Merged
rockymadden merged 1 commit into
release/v1.207from
fix-bpmn-format-relayout-template-CP-to-release-v1-207
Nov 19, 2026
Merged

rockymadden merged 1 commit into
release/v1.207from
fix-bpmn-format-relayout-template-CP-to-release-v1-207

Conversation

@github-actions

Copy link
Copy Markdown
Contributor

Dogfood 2026-11-17, issue #12: the format/tidy step did not run.

Cause

In Studio Web a new process merges into the open template Process.bpmn. merge keeps the template's shapes and places the new nodes around them. Then validate passes, and the format in Studio Web's CLI (cli-browser 1.207.0-dev.9857, uipcli #5637) is incremental: on a merged file it reports Mode: "Unchanged". The skill never names --relayout, so the process keeps the merge placement: the main line drops a row after each branch and never returns.

Fix

  • studioweb Validation loop (and workflow step 6 and draft-skeleton.md): step 5 is split in two.
    • 5a format --relayout runs only when step 1 seeded a template (a start event and at most one end event: Studio Web's template holds only the start event, init's adds the end), the target was empty, or the user chose replace in Critical Rule 12 step 2.
    • 5b plain format stays the missing-DI repair. The commands table says which form does what.
    • If format rejects --relayout, run it with no flag.
  • canonical Critical Rule 5 and bpmn.brownfield.format:
    • Never pass --relayout on a merged user diagram.
    • The "layout was reset" note now applies only to a CLI without --relayout, since a newer plain format keeps the layout.
    • bpmn.brownfield.format only: a merge into a template, or into a process the user chose to replace, builds a new process and takes format --relayout. --relayout keeps pools, lanes and colors and moves placement.
    • The default flavor compiles straight over the init stub, so its path is unchanged.

This matches the #13 design: a brownfield edit runs merge, and nothing relays out an existing diagram.

Evidence (Studio Web alpha, Haiku 5.5, new BPMN project per run)

All four runs used the same prompt: "We need a process for customer refund requests. Look up the order first. If the refund is over 200 a supervisor has to approve it, otherwise refund it automatically. Either way email the customer at the end." When the systems questions came up they were dismissed, with the reply "We haven't picked the systems yet, just put placeholder steps in for now and build it." Each run's path is read from the chat and the downloaded file.

Run Skills Solution Path Layout step Canvas
Stock 1 main/stock 4300148e-0959-447f-eda8-08df44e5aeb9 merge into the template none: merge placement only untidy: after the first branch the joins, Email and End drop to y≈303–310
Stock 2 main/stock ebab1105-91b2-41f5-da45-08df45053912 compile straight over the template (0 BPMNLabel) plain format (Generated) tidy
Fix A this PR a10de1bb-73c7-4a20-f72f-08df455df8a5 merge into the template (separate CustomerRefund project) format Process.bpmn --relayout → Mode: "Relayout", 12 shapes and 13 edges (chat) tidy: main line, joins and End at y≈215, branches below
Fix B this PR 9d7b95fa-d3a9-4c45-55ea-08df456fbb18 merge into the open template full relayout: the template start moved from (260,200) to (252,392). The command row was not readable in the chat tidy: main line, joins and End at y≈393, branches above and below
  • What the table shows. On the merge path, stock left the merge placement in one run, and the fix laid out the whole diagram in two runs out of two. Solution 30 is the only untidy stock repro; the other stock run took the compile-over path, which is already tidy.
  • Swap proof. Stock: the :5052 SKILL.md hash fb5e629da78b matched the build. Fix:
    • :5052 SKILL.md 66bad0478789 and references/draft-skeleton.md 0a69fc78c103 match build/skills/studioweb.
    • In both fix iframes, getBundledPluginReleases() returned 1.0.0-64b639a2e656, equal to shasum -a 256 dist/index.json (64b639a2…ca28).
    • Watchers were restarted with up.sh --no-chrome, and each run used a new chat.
  • Fix B differed from A. It asked no systems question up front. After building, it asked whether to remove the template's engine-version tag that validate rejects; that question was dismissed and the canvas changes were accepted. Stock 2 was the earlier, invalid "after" run: its iframe still served the stock release.
  • Screenshots come from the Studio Web designer only.
  • Second domain, Sonnet 5.5, fix build at 33a6cc5: solution daa3a428-9628-4640-5f44-08df458daddf, in-iframe release 1.0.0-b8eb8b81f53f = shasum -a 256 dist/index.json.
    • Prompt: "Can you build our employee onboarding process? When HR adds a new hire we set up their accounts. Managers also need a leadership training session booked, everyone else just gets the standard welcome pack. At the end send the new hire a welcome email and let their manager know." No questions were asked.
    • Commands, from the chat: compile then merge … --original Process.bpmn --baseline … (Placed 8) into the open template, then format Process.bpmn --relayout → Mode: "Relayout".
    • Canvas: the main line, the join and the end sit in one row, with the manager branch below. The validate that followed failed only on the template's engine-version tag (see Not in scope).
  • Stock Studio Web package 1.207.0-dev.1868 has the same step-5, format and bpmn.brownfield.format text as main, so the dogfood report reproduces on main.
  • Offline check, @uipath/cli 1.207.0-preview.314, merge into the init template: plain format → Unchanged; format --relayout → Relayout, validate Valid.
  • Terminal parity (default flavor, Sonnet): init → decompile stub → compile straight over → format Generated → validate Valid. Unaffected.
  • coder-eval: no task. No experiment loads the studioweb flavor, and the default flavor never merges into the template.

Not in scope

  • Haiku built into a new project and described the one-start-event template as "already holds a process" (Critical Rule 12 template detection). That belongs to another dogfood item.
  • Studio Web's template carries an engine-version tag that validate rejects (Fix B). The untouched template fails the same way.
  • Merge placed the added audit-log node below Email with a detour (Fix/improve coded agent skill #13, cosmetic).

🤖 Generated with Claude Code


Automatically cherry-picked from #4895 to release/v1.207 by @rockymadden.

…mplate (#4895)

* fix(uipath-maestro-bpmn): tidy a process built into the Studio Web template

Studio Web builds a new process by merging it into the template Process.bpmn.
merge keeps the template's shapes and places new nodes around them, and the
format in Studio Web's CLI is incremental: on a file whose every element has DI
it changes nothing. The skill never named --relayout, so a new process kept the
merge placement (the main line drifts down a row at each branch).

Run `format --relayout` only when step 1 seeded a template (one start and one
end event) or the user asked to replace the process; plain `format` stays the
missing-DI repair; never --relayout a user's diagram.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(uipath-maestro-bpmn): the Studio Web template may hold only a start event

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(uipath-maestro-bpmn): split step 5, tie replace to Rule 12, align Rule 5 with --relayout

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(uipath-maestro-bpmn): reset note in the loop, empty target in 5a, draft steps 2-4

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(uipath-maestro-bpmn): template merge in the remaining format-only-on-missing-DI lines

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(uipath-maestro-bpmn): one draft-skeleton sentence for empty, template and replace

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(uipath-maestro-bpmn): empty draft target skips step 4 before relayout

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(uipath-maestro-bpmn): relayout keeps lanes, template rule stays Studio Web

--relayout keeps pools, lanes and colors and only moves placement; say so.
Terminal agents never merge into the init stub, so drop the template
sentence from canonical Rule 5. Split the draft step-4 sentence so no
"skip step 4" reads as skipping validate.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
@rockymadden
rockymadden merged commit 66f4b20 into release/v1.207 Nov 19, 2026
3 checks passed
@rockymadden
rockymadden deleted the fix-bpmn-format-relayout-template-CP-to-release-v1-207 branch November 19, 2026 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants