Repository navigation
🍒 [v1.207] fix(uipath-maestro-bpmn): author every expression as =js: (a plain = opens in the C# editor) - #4995
Merged
rockymadden merged 1 commit intoNov 19, 2026
Conversation
…opens in the C# editor) (#4891) * test(uipath-maestro-bpmn): canvas-ready grader for =js: expressions and input scoping (WIP) check_canvas_ready.py --check js|scope; canvas_ready.yaml grades the js half. Dogfood 2026-11-17 issues 6 and 7. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(uipath-maestro-bpmn): author every expression as =js: (a plain = opens in the designer's C# editor) Rule bpmn.expression.js-for-methods now says =js: in any field, keeping plain only the forms the canvas writes plain. Examples and patterns converted. Grader scans every attribute, text and JSON-body string. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * test(uipath-maestro-bpmn): contract test guards =js: in authored expressions Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(uipath-maestro-bpmn): human-task form inputs stay plain; =js: rule at point of use in SKILL.md Review round 1: the canvas writes a form field's value as plain =vars.<id> (quickFormDerivation.ts); check's EXPR_BARE_VAR_REF hint drops js:; an import's plain expressions are C#. A green replicate that skipped bpmn-runtime.md wrote plain end-event rows, so Critical Rule 4 now carries the rule. Grader flags =true and declared bare reads, exempts form inputs; contract test covers literals. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs(uipath-maestro-bpmn): InvoiceApproval header says its plain = expressions are legacy C# Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(uipath-maestro-bpmn): review round 2 — Rule 4 names the form-value exemption; grader exempts form output fields Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * test(uipath-maestro-bpmn): unit-test the canvas_ready grader; review round 3 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * test(uipath-maestro-bpmn): grader tests cover JSON bodies, agent outputs, canvas reads, script envelope Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(uipath-maestro-bpmn): review round — SKILL.md under the 40 KB cap; grader skips literal names and requires an =js: expression - SKILL.md Rule 4 line cut to the must-do plus a link to the exceptions (39,998 bytes). - check_canvas_ready --check js no longer scans id/name attributes, documentation or annotation text, and fails a process with no =js: expression; BARE_FIELD notes its typo gap. - Unit cases for literal names and a process that computes nothing; contract test renamed test_authored_exprs_are_js. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(uipath-maestro-bpmn): canvas grader's scope check fails closed --check scope parsed validate's Warnings by regex over a JSON dump, so a changed report shape passed as no unset reads. It now requires Status Valid, a text Warnings with the known header and `- [<element>] <CODE>` lines, and fails on anything else. Unit tests stub `uip` with the real warning format. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
github-actions
Bot
requested review from
a team,
astridstaicu,
dmetzgar and
tmatup
as code owners
November 19, 2026 15:30
rockymadden
added a commit
that referenced
this pull request
Nov 19, 2026
dmetzgar
approved these changes
Nov 19, 2026
rockymadden
deleted the
claude-fix-bpmn-js-prefix-a0eee1-CP-to-release-v1-207
branch
November 19, 2026 20:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dogfood 2026-11-17, issue #7: the Studio Web designer opens a plain
=expression in its C# editor. The BPMN skill said plain=was fine unless the expression called a JavaScript method, and every authored example used=vars….Change
bpmn.expression.js-everywhere(renamed fromjs-for-methods, inreferences/bpmn-runtime.md): write every authored expression as=js:, in any field. Plain=stays only for the forms the canvas writes plain:=result…,=response…,=Error=Action,=Decision=bindings.<id>and=iterator[0]value(=vars.<id>, per PO.FrontendquickFormDerivation.ts)The rule also says an import's existing plain
=expressions are C#: leave them as they are, and copy none of them.SKILL.md) gets the same point-of-use sentence. Rule 4 and the studiowebworkflow-compileblock also note thatcheck'sEXPR_BARE_VAR_REFhint dropsjs:.=vars.→=js:vars.. TheInvoiceApproval.bpmn.tsbody is unchanged, since it is a real canvas import. Its header now says its plain expressions are legacy C#.expressions/canvas_readywith gradercheck_canvas_ready.py --check js. The grader scans every attribute, element text and JSON-body string._shared/test_check_canvas_ready.py.test_authored_expressions_are_javascript, with 15 failures on main and 0 here.Evidence
coder-eval
canvas_ready(Claude Code, default experiment):=vars.loyaltyTier == "Gold",=0.1,=vars.orderTotal * vars.discountRatebpmn-runtime.mdonly956a35d76(same skill content as65e35615d; Rule 4 line + header note)Terminal parity (Claude Code subagents on this branch): Haiku with the dogfood BPMN UC1 prompt verbatim, and Opus with a new loan pre-check prompt. Both wrote every expression as
=js:.SDK 6.104.1 passes
=js:through unchanged, andcheckstill reportsEXPR_UNDECLARED_REFinside=js:.Autopilot, Studio Web designer (alpha, local Autopilot stack on this branch's studioweb build, head
65e35615d; same skill content as956a35d76):getBundledPluginReleases()=1.0.0-11293237a501, andsha256(dist/index.json)=11293237a501d2fb…. Servedbpmn-runtime.mdand build copy are bothb3be42d2….=js:. Clickingpayout(vars.stake * 2) opens the JS Expression editor, the Health analyzer shows No issues found, and a debug run (betred, amount10) finished Successful.=js:.=js:.=appears only where the canvas writes it plain:=result.response…and the start-event input rows.=vars.amount * 2,=0and plain end rows, and the designer opened the C# expression editor. Opus on that release quoted the oldjs-for-methodstext when asked why.check_canvas_ready.py --check js: the 3 after-builds print OK, and the pre-fix build FAILs.after-haiku-uc1-js-editor.png,after-haiku-uc1-health-no-issues.png,after-haiku-uc1-debug-successful.pngandbefore-haiku-uc1-csharp-editor-stale-release.png(shared dogfood evidence folder,issue-7/).Follow-up
maestro/bpmn-set-literal-values.md, a per-user note written by an earlier session, teachesset: { payout: "=0" }. It is not repo content, so this PR leaves it alone.expressions/computed_jsandexpressions/error_mappingtask prompts still teach plain=vars.…. Their graders don't penalize=js:.🤖 Generated with Claude Code
Automatically cherry-picked from #4891 to
release/v1.207by @rockymadden.