Skip to content

🍒 [v1.207] fix(uipath-maestro-bpmn): author every expression as =js: (a plain = opens in the C# editor) - #4995

Merged
rockymadden merged 1 commit into
release/v1.207from
claude-fix-bpmn-js-prefix-a0eee1-CP-to-release-v1-207
Nov 19, 2026
Merged

rockymadden merged 1 commit into
release/v1.207from
claude-fix-bpmn-js-prefix-a0eee1-CP-to-release-v1-207

Conversation

@github-actions

Copy link
Copy Markdown
Contributor

Dogfood 2026-11-17, issue #7: the Studio Web designer opens a plain = expression in its C# editor. The BPMN skill said plain = was fine unless the expression called a JavaScript method, and every authored example used =vars….

Change

  • Rule bpmn.expression.js-everywhere (renamed from js-for-methods, in references/bpmn-runtime.md): write every authored expression as =js:, in any field. Plain = stays only for the forms the canvas writes plain:
    • node-result reads: =result…, =response…, =Error
    • form and agent fields: =Action, =Decision
    • =bindings.<id> and =iterator[0]
    • the start-event input row
    • a human-task form field's value (=vars.<id>, per PO.Frontend quickFormDerivation.ts)
      The rule also says an import's existing plain = expressions are C#: leave them as they are, and copy none of them.
  • Critical Rule 4 (SKILL.md) gets the same point-of-use sentence. Rule 4 and the studioweb workflow-compile block also note that check's EXPR_BARE_VAR_REF hint drops js:.
  • Examples and patterns: =vars. → =js:vars.. The InvoiceApproval.bpmn.ts body is unchanged, since it is a real canvas import. Its header now says its plain expressions are legacy C#.
  • Tests:
    • New task expressions/canvas_ready with grader check_canvas_ready.py --check js. The grader scans every attribute, element text and JSON-body string.
    • A unit test for the grader, _shared/test_check_canvas_ready.py.
    • A contract test, test_authored_expressions_are_javascript, with 15 failures on main and 0 here.

Evidence

  • coder-eval canvas_ready (Claude Code, default experiment):

    skill score
    main 0.455 FAIL: plain =vars.loyaltyTier == "Gold", =0.1, =vars.orderTotal * vars.discountRate
    rule in bpmn-runtime.md only 3/4 pass: the failing run never opened the reference and copied InvoiceApproval's plain end rows
    head 956a35d76 (same skill content as 65e35615d; Rule 4 line + header note) 5/5 pass (1.000)
  • Terminal parity (Claude Code subagents on this branch): Haiku with the dogfood BPMN UC1 prompt verbatim, and Opus with a new loan pre-check prompt. Both wrote every expression as =js:.

  • SDK 6.104.1 passes =js: through unchanged, and check still reports EXPR_UNDECLARED_REF inside =js:.

  • Autopilot, Studio Web designer (alpha, local Autopilot stack on this branch's studioweb build, head 65e35615d; same skill content as 956a35d76):

    • Swap proof, checked inside the Autopilot iframe: getBundledPluginReleases() = 1.0.0-11293237a501, and sha256(dist/index.json) = 11293237a501d2fb…. Served bpmn-runtime.md and build copy are both b3be42d2….
    • Dogfood BPMN UC1 prompt, verbatim:
      • Haiku 5.5: every authored expression is =js:. Clicking payout (vars.stake * 2) opens the JS Expression editor, the Health analyzer shows No issues found, and a debug run (bet red, amount 10) finished Successful.
      • Opus 5.5: all =js:.
    • New loan pre-check prompt, Haiku 5.5: all =js:.
    • Plain = appears only where the canvas writes it plain: =result.response… and the start-event input rows.
    • None of the runs asked a clarifying question.
    • Before: the same UC1 prompt on the pre-fix skill release (Haiku) wrote =vars.amount * 2, =0 and plain end rows, and the designer opened the C# expression editor. Opus on that release quoted the old js-for-methods text when asked why.
    • check_canvas_ready.py --check js: the 3 after-builds print OK, and the pre-fix build FAILs.
    • Screenshots are from the Studio Web designer: after-haiku-uc1-js-editor.png, after-haiku-uc1-health-no-issues.png, after-haiku-uc1-debug-successful.png and before-haiku-uc1-csharp-editor-stale-release.png (shared dogfood evidence folder, issue-7/).

Follow-up

  • Autopilot Knowledge maestro/bpmn-set-literal-values.md, a per-user note written by an earlier session, teaches set: { payout: "=0" }. It is not repo content, so this PR leaves it alone.
  • The expressions/computed_js and expressions/error_mapping task prompts still teach plain =vars.…. Their graders don't penalize =js:.

🤖 Generated with Claude Code


Automatically cherry-picked from #4891 to release/v1.207 by @rockymadden.

…opens in the C# editor) (#4891)

* test(uipath-maestro-bpmn): canvas-ready grader for =js: expressions and input scoping (WIP)

check_canvas_ready.py --check js|scope; canvas_ready.yaml grades the js half.
Dogfood 2026-11-17 issues 6 and 7.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(uipath-maestro-bpmn): author every expression as =js: (a plain = opens in the designer's C# editor)

Rule bpmn.expression.js-for-methods now says =js: in any field, keeping plain only
the forms the canvas writes plain. Examples and patterns converted. Grader scans
every attribute, text and JSON-body string.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* test(uipath-maestro-bpmn): contract test guards =js: in authored expressions

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(uipath-maestro-bpmn): human-task form inputs stay plain; =js: rule at point of use in SKILL.md

Review round 1: the canvas writes a form field's value as plain =vars.<id>
(quickFormDerivation.ts); check's EXPR_BARE_VAR_REF hint drops js:; an import's
plain expressions are C#. A green replicate that skipped bpmn-runtime.md wrote
plain end-event rows, so Critical Rule 4 now carries the rule. Grader flags =true
and declared bare reads, exempts form inputs; contract test covers literals.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* docs(uipath-maestro-bpmn): InvoiceApproval header says its plain = expressions are legacy C#

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(uipath-maestro-bpmn): review round 2 — Rule 4 names the form-value exemption; grader exempts form output fields

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* test(uipath-maestro-bpmn): unit-test the canvas_ready grader; review round 3

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* test(uipath-maestro-bpmn): grader tests cover JSON bodies, agent outputs, canvas reads, script envelope

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(uipath-maestro-bpmn): review round — SKILL.md under the 40 KB cap; grader skips literal names and requires an =js: expression

- SKILL.md Rule 4 line cut to the must-do plus a link to the exceptions (39,998 bytes).
- check_canvas_ready --check js no longer scans id/name attributes, documentation or annotation text, and fails a process with no =js: expression; BARE_FIELD notes its typo gap.
- Unit cases for literal names and a process that computes nothing; contract test renamed test_authored_exprs_are_js.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(uipath-maestro-bpmn): canvas grader's scope check fails closed

--check scope parsed validate's Warnings by regex over a JSON dump, so a changed report shape passed as no unset reads. It now requires Status Valid, a text Warnings with the known header and `- [<element>] <CODE>` lines, and fails on anything else. Unit tests stub `uip` with the real warning format.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
@rockymadden
rockymadden merged commit fe64d78 into release/v1.207 Nov 19, 2026
3 checks passed
@rockymadden
rockymadden deleted the claude-fix-bpmn-js-prefix-a0eee1-CP-to-release-v1-207 branch November 19, 2026 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants