Repository navigation
fix(uipath-maestro-bpmn): read a process input through the start event's mapping - #4892
Conversation
…nd input scoping (WIP) check_canvas_ready.py --check js|scope; canvas_ready.yaml grades the js half. Dogfood 2026-11-17 issues 6 and 7. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…t's mapping A process input belongs to the start event. A later step that reads vars.<inputId> is "A variable is unresolved" on the Studio Web canvas, and validate only warns VARIABLE_NOT_SET (dogfood 2026-11-17, issue 6). The rule bpmn.variables.read-inputs-directly taught exactly that read, and the InvoiceEscalation example and the queue pattern showed it. Replace the rule with the canvas's own shape: map each input on the start event into a variable scoped to it, then read that variable downstream. Fix both examples and the draft-skeleton line the same way. Add the input_scope task, graded by check_canvas_ready.py --check scope. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
With the rule only in bpmn-runtime.md, input_scope passed 2 of 3 runs. The failing run never opened the reference and read vars.<inputId> directly. Rule 11 already says outputs go out through the end event. Add the matching sentence for inputs through the start event: 5 of 5 runs then pass. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Declare the snippet's written variable. Say why a start-event row needs a `.var()`, unlike a task row. Read the existing mapping in a canvas-made process. Draft decisions read the mapped variable. The eval now requires declared inputs, so the scope check cannot pass on a process that has none. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… may write the input mapping Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…oped to Event_start Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…rs only Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…, inputs never warn Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The count was wrong for one more start shape each round (mapped inputs, input collections, timer and message starts). The warning text is enough. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…hrough the start mapping Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… reading an input Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Claude finished @DevMomo's task in 59s —— View job Coder-eval task lint (advisory)2 task YAMLs changed. Verdicts: 0 Critical, 1 High, 0 Medium, 1 Low, 0 OK. Rubric: .claude/commands/lint-task.md. This check is advisory and never blocks merge. Evidence of passing run
Per-task lint
|
|
Claude finished @DevMomo's task in 2m 25s —— View job SummaryThis PR replaces rule Change-by-Change Review1.
|
| Area | Status | Notes |
|---|---|---|
| Frontmatter | OK | Unchanged |
| E2E Tests | Issue | canvas_ready grades an untaught contract and is out of scope; input_scope OK |
| Skill Body | OK | Rule 11 grew longer but is justified by evals |
| References & Assets | Issue | draft-skeleton expected-vs-actionable VARIABLE_NOT_SET is ambiguous |
| Repo Hygiene | OK | No secrets or personal paths; no new skill, so no CODEOWNERS or registry change needed; edits stay outside flavor blocks |
Issues for Manual Review
- Confirm the warning code behind
Variable "vars.<id>" is read but never assigned. If it is notVARIABLE_NOT_SET, finding feat: new coded agent skills #2 drops to Low.uipis not installed on this runner, so I couldn't check. - Confirm that
.var(id, type, { elementId })compiles to auipath:variableand not auipath:inputwithelementId. Otherwisecheck_inputs_declared.pycounts mapped vars as inputs, and the ≥2 guard passes when it shouldn't. - Row
nameconvention:InvoiceEscalationuses the input's display name ('Invoice ID'), while thebpmn-runtime.mdexample uses the id ('amount', which has no display name). Both look consistent with "the input's display name", but someone should confirm this against canvas output.
Conclusion
Approve after the two Medium fixes. The core rule change is correct, well evidenced, and applied consistently. Before merge:
- Make the draft-skeleton
VARIABLE_NOT_SETguidance distinguish input reads from skeleton.var()reads. - Remove
canvas_ready.yaml(or move it to the chore: compact skills #7 PR) so this PR doesn't ship a task the skill is guaranteed to fail.
|
Two notes from the SDK side (builder-sdk #2138 / #2144):
|
The js half of the grader belongs to #4891: its task fails here by design and the two grader copies would conflict. input_scope uses --check scope, whose logic is identical in both copies. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ows self-declare Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… after the rule it excepts Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…the start mapping Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…omputed result reads - bpmn-runtime.md: js-everywhere keeps #4833's warning for plain = expressions an agent keeps or edits (.length reads null; use .Count; .length only inside =js:). - Contract test: FORM_VALUE also exempts the start-event row source: '=vars.<inputId>', var: (#4892 writes these). - Grader: RESULT_READ exempts only a bare result/response/Error/iterator path, so a computed plain expression fails --check js. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
jiyangzh
left a comment
There was a problem hiding this comment.
Recommendation: 🟢 Approved. The rule is correct and every input read in the skill now goes through the start event. Findings are minor.
What
Replaces bpmn.variables.read-inputs-directly with bpmn.variables.inputs-through-start. A step reads an input through a .var() that the start event's BPMN.Variables row maps it into. Updates InvoiceEscalation, the queue guide, Critical Rule 11 and draft-skeleton.md. Adds the input_scope eval.
Overall findings
- minor: stale grader comment.
tests/tasks/uipath-maestro-bpmn/e2e/api_workflow_composition/check_shape.pylines 44-45 and 578 still callVARIABLE_NOT_SETon a start-scoped input "expected BY CONSTRUCTION (the BPMN skill's own guidance)". The skill now says the opposite. Fix: reword both comments to say the leniency is for that grader only. - minor:
input_scopecannot tell a process that maps its inputs from one that never reads them. Declaring two inputs and ignoring them passes. The fee logic is also ungraded. Fix: add a check that a=js:expression reads a start-mapped variable, and that3and20appear. - Overlap and merge order: #4891 edits the same six skill files and also adds
check_canvas_ready.py(add/add conflict; the PR calls its copy identical). The examples here use plain=('=vars.item'in the queue guide,'=vars.invoiceIdIn'in the form field). #4891 rewrites those to=js:. Land #4891 first and rebase. The start-rowsource: '=vars.<inputId>'stays plain; the grader exempts it. #4829 conflicts on thedraft-skeleton.mdwarning rule (already agreed in thread). #4899 also editsSKILL.mdanddraft-skeleton.md. - Checked: all
.input(examples in the skill now use the bridge (no direct read left).uipvalidateand the canvas message were not run; the canvas behavior rests on the PR's designer evidence.
tl;dr
Approve. Land after #4891 and settle #4829's wording. Two small test and comment fixes.
rockymadden
left a comment
There was a problem hiding this comment.
🟢 Approved: No blockers; 3 non-blockers remain.
What
- Teaches start-event mappings for process inputs so downstream references resolve on the canvas.
Axes
| Axis | Blockers | Non-blockers | Top finding |
|---|---|---|---|
| Correctness & logic | 0 | 0 | none |
| Code quality & simplicity | 0 | 0 | none |
| Types & contracts | 0 | 0 | none |
| Tests & validation | 0 | 2 | Unused inputs pass the regression · tests/tasks/uipath-maestro-bpmn/expressions/input_scope/check_inputs_declared.py:18 |
| Security | 0 | 0 | none |
| Architecture & design | 0 | 0 | none |
| Error handling & resilience | 0 | 0 | none |
| Interface, docs & compatibility | 0 | 1 | Existing task still teaches direct reads |
Overall findings
💬 Non-blocker · Interface, docs & compatibility
tests/tasks/uipath-maestro-bpmn/e2e/api_workflow_composition/check_shape.py:43 and :578 still describe VARIABLE_NOT_SET on a direct start-input read as expected and consistent with the skill. This PR reverses that guidance.
Update the stale explanation and migrate the exemption/fixture to the documented bridge where applicable.
💬 Non-blocker · Tests & validation
The smoke run passes 28/32 tasks, below the 95% gate. The new input-scope task passes, but four other tasks fail. One registry-list check timed out; I could not establish the cause of the remaining failures.
Inspect the failed criteria and fix any regression, or document evidence that the failures are unrelated.
Validation
- Checked the SDK/Designer input-scope contract, canonical guidance and frozen flavors. No drift found; no local execution.
- The new task passes in CI; the red smoke run is recorded above.
tl;dr: The guidance is consistent. Strengthen the scope regression and update the stale task assumptions.
…; drop loop-collection aside Unused inputs passed input_scope; now an input counts only when a start event maps it and a later step reads the mapped var. check_shape's comments no longer call VARIABLE_NOT_SET on an input the skill's guidance. Re-sync check_canvas_ready.py with #4891. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Review-body findings, fixed in ac0ce4f: |
…coping-cd22cb # Conflicts: # skills/uipath-maestro-bpmn/references/patterns/queue-distribution-guide.md
skill-lint: 0 new errors, 1 new warning
What these rules check
Only what this PR adds is listed, compared with the commit it branched from; issues already on the base branch are not. Updated on every push. |
Takes main's Critical Rule 11 (#4892: a step reads an input through the start event's mapping) and keeps Rule 12 after it, without its no-edit exception for VARIABLE_NOT_SET on an input, which #4892 makes a real bug. Renumbers main's new flavor references to the main-file rule (now 13). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… clean report With #4892 an input VARIABLE_NOT_SET is fixed like any other warning, so the final report no longer has a sentence for it. When validate keeps no warning, the judge now requires the report to mention none. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Dogfood 2026-11-17, issue 6. Covers part of #9 (see below).
Problem
The canvas scopes a process input to the start event. A later step that reads
vars.<inputId>shows "A variable is unresolved" in the designer.uip maestro bpmn validatestill passes, with at most aVARIABLE_NOT_SETwarning (none for a loop's collection) that agents wave off. Rulebpmn.variables.read-inputs-directlytaught that read, and theInvoiceEscalationexample and the queue pattern showed it. The shippedInvoiceEscalationgives 3×VARIABLE_NOT_SETon its own.Source of truth is PO.Frontend develop (
VariableValidationUtils.ts,VariableScopeUtils.ts,UnifiedBuildDataManager.tsx). A step can read root-scoped variables and upstream nodes' output rows. An input declared on the start event is neither. When the canvas adds an input, it writes a start-event output row (source: '=vars.<inputId>') into a variable scoped to the start event.Fix
bpmn-runtime.md: replace the rule withbpmn.variables.inputs-through-start, which shows the canvas shape. Unlike a task row, a start-event row does not declare its variable, so the.var(…, { elementId })is required (without itcheckfailsEXPR_UNDECLARED_REF). In a canvas-made process, read the existing row'svar; add no second row.InvoiceEscalation.bpmn.tsandqueue-distribution-guide.mdnow use that shape. Canvas engine: 0 errors (was 3×VARIABLE_NOT_SETon the example). The queue example validates with noVARIABLE_NOT_SET.SKILL.mdCritical Rule 11: one sentence for inputs, matching its outputs half; no new rule number.draft-skeleton.md: a decision or a per-item box's collection reads the variable the start event maps an input into, and the skeleton writes that mapping;VARIABLE_NOT_SETis no longer an ignorable skeleton warning.expressions/input_scope(parking fee), graded bycheck_inputs_declared.py(≥2 inputs the start event maps and a later step reads, so the scope check is not vacuous) andcheck_canvas_ready.py --check scope. The grader is fix(uipath-maestro-bpmn): author every expression as =js: (a plain = opens in the C# editor) #4891's exact copy; itscanvas_readytask belongs to fix(uipath-maestro-bpmn): author every expression as =js: (a plain = opens in the C# editor) #4891 and is not in this PR.Evidence
computeFeeVARIABLE_NOT_SET).bpmn-runtime.mdonly: 2/3 (the failing run never opened the reference and readvars.<inputId>directly). That is why Critical Rule 11 in SKILL.md gets one sentence for inputs, matching what it already says for outputs.--check scope): 5/5 valid replicates pass. A 6th replicate failed, but its Skill tool loaded another worktree's skill copy with the old rule (harness leak, excluded).52c734e52):input_scope4/4 and dogfood UC1 parity 4/4, all at score 1.000. The commits after it changedraft-skeleton.mdand add "(none for a loop's collection)" to Critical Rule 11 andbpmn-runtime.md(dropped again inac0ce4f2c). The draft-skeleton smoke tasks pass on them (deterministic graders; the LLM judge needs CI).d21c26052:input_scope3/3 at score 1.000. Head (4ac71ca26, fix(uipath-maestro-bpmn): author every expression as =js: (a plain = opens in the C# editor) #4891's grader):input_scope1/1 at score 1.000; the old and new grader give the same--check scopeverdict on all 7 saved red and green runs.a8b15ef850db): the 2026-11-17 dogfood repro (UC1 roulette, Haiku 5.5) showed "A variable is unresolved" onvars.betAmount * 2. Re-run on 2026-11-18, it was 3/3 canvas-clean: UC1 on Haiku twice, ParkingFee on Sonnet once. The models copied the end-event mapping into root variables. So stock is not deterministic, and the coder-eval red on main (0.455) is the reproducible before.d21c26052build (release493707475fba): 3/3 canvas-clean (canvas engine 0 findings). UC1 on Haiku 5.5, ParkingFee on Sonnet 5.5, and a new library-fine prompt on GPT-6.1 Sol. Every run mapped inputs on the start event into.var(..., { elementId: 'Event_start' })and read those downstream (betAmountIn,hoursIn,daysOverdueIn).Math.min(vars.hoursIn * 3, …)with no unresolved marker. A debug run with inputs 10 hours and no pass succeeded (instance1eba80a1-c39e-4a8a-b95e-0ee2ce82a599). The start event outputHoursIn: 10, HasPassIn: falseand the end event outputFee: 20, so the inputs arrived.4ac71ca26(releasef12badec68ed) and final head0ef0b3b0b(release978cfff25cd1): UC1 on Haiku 5.5 is canvas-clean (canvas engine 0 findings) both times and reads the inputs through the start mapping (betAmountIn/betColorIn, thenbetIn/amountIn). The commits after4ac71ca26change onlybpmn-runtime.mdandqueue-distribution-guide.mdwording.getBundledPluginReleases()indexSha256 equalsshasum -a 256 dist/index.json:493707475fba5326a02f1dd822250c5814610f37b079d4b77f6d8cc3c3b92f19ford21c26052,f12badec68ed5d6a0a67568ac30808a07024c942cba0f5083c35b8e056250743for4ac71ca26,978cfff25cd17f8e1aff69195b3c71dfdd194483f22fb5e39c34314de5450e37for0ef0b3b0b(stock:a8b15ef850db32fa217170afba8f46c1be91231a14cd2cdcc11c9754b413bd77).:5052 …/uipath-maestro-bpmn/references/bpmn-runtime.mdand the build copy are both sha1e90383932b7096af4191a018383c8fee14a2d33f(d21c26052)5940be7ead9500fd286d3dd77b71f8c75b31964e(4ac71ca26) and01494e7fd0aee09c82d603fcee27cb099df87d51(0ef0b3b0b).#9
"Autopilot generated a BPMN that has validation issues" has no artifact attached. The warnings an Autopilot BPMN gets are
VARIABLE_NOT_SET(this PR), the plain-=C# expressions (#7),maestroEngineVersion(#5), and the parse warningunknown attribute <type>. That last one also appears on the shipped examples and is not caused by this PR.unknown attribute <type>traced: it comes from<uipath:inputSchema type="jsonSchema">, which.scriptTask()and.humanTask()write (InvoiceEscalation carries two, onpostandapprove;validateprints the warning once, and removing both attributes clears it). The canvas writes the same attribute (PO.Frontend develop,bpmn-moddle.tscreateInputSchema), but its descriptoruipath-moddle.v1.jsonInputSchemadeclares onlybody. So the canvas warns on its own output. This is a PO.Frontend descriptor gap and harmless: neither the SDK nor the skill needs a change.Follow-up (SDK)
.input()already scopes the input to the start event but doesn't emit the bridge, and a start-event payload row doesn't declare its own variable the way a task's output row does. If the SDK emitted the bridge, this rule would not be needed.🤖 Generated with Claude Code