Repository navigation
🍒 [v1.207] test(flow): clear leaked IXP debug folders and refuse a project-less IXP node in the handoff seed - #4885
Merged
rockymadden merged 1 commit intoNov 18, 2026
Conversation
…IXP node in the handoff seed (#4669) * test(flow): fail ixp handoff seed on a domain node with no project Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> * test(flow): clean up ixp handoff Debug_ folders Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> * test(flow): fix sweep docstring Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> * test(flow): find debug folders through the plain folder listing Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> * test(flow): match ghost IXP nodes by DeploymentName and scope Debug_ teardown to new folders Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> * test(flow): leave Debug_ folders to the seed sweep and re-list projects before the ghost check Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> * test(flow): bound the Debug_ sweep and name the ghost's folder key in the seed error Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> * test(flow): re-pull the registry before judging a ghost node again Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Sonnet 5.5 <noreply@anthropic.com>
github-actions
Bot
requested review from
a team,
constantinmuraru and
vlad-crisan
as code owners
November 17, 2026 21:15
roberts-cliff
approved these changes
Nov 17, 2026
roberts-cliff
approved these changes
Nov 17, 2026
roberts-cliff
left a comment
Contributor
There was a problem hiding this comment.
Cherry-pick reviewed — diff matches source. LGTM.
dmetzgar
approved these changes
Nov 17, 2026
rockymadden
deleted the
test-flow-ixp-cleanup-debug-folders-CP-to-release-v1-207
branch
November 18, 2026 14:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Two causes of the same failure:
skill-flow-ixp-e2e-project-creation-handoff(and e2e_04, which shares the seed) is polluted by IXP state that outlives its project.Debug_*folders.uip maestro flow debugdeploys a flow's packages intoDebug_<project>under the caller's Personal Workspace. The handoff teardown only deletes the seed'sflow-e2e-*folder, so those processes stay bound to their packages, the package sweep gets HTTP 409 forever, and the deployment plus its registry node survive the swept project. Evidence: e2e_04 does not forbidflow debug, and 5Falconry*packages are stuck.falconry-licences-...-ixpnode after its project is gone (ixp deployments get-taxonomy404, not inixp projects list). The agent reuses it, so the routing test becomes a reuse test (scored 0.379,skill_triggered uipath-ixpfailed). Deployments have no delete verb; only their Orchestrator folder removes them.Change (
e2e_03_project_creation_handoff/_setup/handoff.py)Debug_*folders: runs share one Personal Workspace and prompt, so aDebug_<N>orDebug_<N> 1cannot be attributed to a run. Leaked ones are cleared by the seed sweep below.sweep_debug_folders(): deletes aDebug_*folder only when every process in it is a fixture-domain package and every one of those versions is older than the existing 7200s window. Any otherDebug_*folder is left alone.require_no_ghost_nodes(): runsregistry pull --forceandregistry search uipath.ixp. A node matching the fixture domain raises a "tenant not ready" error. The segment afteruipath.ixp.is the registry-sanitized DeploymentName, so it is matched against each live project's sanitized Name and sanitized deployment names (ixp deployments list, fixture-domain projects first, only while a node is unmatched). TheDebug_sweep stops after 120s of seed (SWEEP_BUDGET_SECONDS), and the ghost error names each node's folder key. On a candidate ghost the project list is re-read and the registry re-pulled once before raising, so a sibling that published after the first listing is not flagged. pre_run failure lands as ERROR, likepreflight_connections.py. Nothing is deleted. Projects swept in the same seed are excluded from the project list, and the Debug_ sweep runs before this check, so a swept folder's node no longer trips it.Verify
cd tests/tasks/uipath-maestro-flow/ixp/e2e_03_project_creation_handoff && uv run --with pytest pytest test_handoff.py -q: 75 passed on the head; the fullixpand_sharedsuites pass (1942).sweep_debug_folders()call turnstest_seed_sweeps_a_stale_fixture_debug_folder_before_its_packagesandtest_seed_keeps_a_young_fixture_debug_folderred.require_no_ghost_nodes()call turnstest_seed_errors_on_a_domain_node_with_no_projectred.test_teardown_leaves_every_debug_folder_alonered (siblingDebug_Proj 1and a non-fixtureDebug_Proj); removing the re-list turnstest_seed_relists_projects_before_calling_a_node_a_ghostred; restoring the raw-Name ghost comparison turns 4 tests red.uip maestro flow initplusflow debugcreatedDebug_<project>(TypeDebugSolution, under the caller's Personal Workspace).or folders list --all --name Debug_<project>returned nothing, so the code lists with plainor folders list(paged, filtered on Type and theDebug_prefix). That folder delete was the live-verified path (now used by the seed sweep only). A rerun of a project lands inDebug_<N> 1.codereval/DefaultTenant(ghost part): the real seed passes on a tenant with no ghost; the node/project check raises on a registry node with no project (using a non-fixture marker).Not verified
Debug_*folder exists to sweep. It sees only folders the caller can list.Debug_LicenceExpiryLogin coder-eval-bot's workspace) is deleted. The new sweep removes it only if the caller can list it and it is older than 7200s and fixture-only; otherwise the seed errors on that tenant until an owner deletes it.skill-flow-ixp-e2e-project-creation-handoffande2e_04_build_mechanics.Supersedes #4660.
🤖 Generated with Claude Code
Automatically cherry-picked from #4669 to
release/v1.207by @rockymadden.