Skip to content

🍒 [v1.207] test(flow): clear leaked IXP debug folders and refuse a project-less IXP node in the handoff seed - #4885

Merged
rockymadden merged 1 commit into
release/v1.207from
test-flow-ixp-cleanup-debug-folders-CP-to-release-v1-207
Nov 18, 2026
Merged

rockymadden merged 1 commit into
release/v1.207from
test-flow-ixp-cleanup-debug-folders-CP-to-release-v1-207

Conversation

@github-actions

Copy link
Copy Markdown
Contributor

What

Two causes of the same failure: skill-flow-ixp-e2e-project-creation-handoff (and e2e_04, which shares the seed) is polluted by IXP state that outlives its project.

  1. Leaked Debug_* folders. uip maestro flow debug deploys a flow's packages into Debug_<project> under the caller's Personal Workspace. The handoff teardown only deletes the seed's flow-e2e-* folder, so those processes stay bound to their packages, the package sweep gets HTTP 409 forever, and the deployment plus its registry node survive the swept project. Evidence: e2e_04 does not forbid flow debug, and 5 Falconry* packages are stuck.
  2. A deployment with no project (ghost node). The registry keeps serving a published falconry-licences-...-ixp node after its project is gone (ixp deployments get-taxonomy 404, not in ixp projects list). The agent reuses it, so the routing test becomes a reuse test (scored 0.379, skill_triggered uipath-ixp failed). Deployments have no delete verb; only their Orchestrator folder removes them.

Change (e2e_03_project_creation_handoff/_setup/handoff.py)

  • Teardown does not delete Debug_* folders: runs share one Personal Workspace and prompt, so a Debug_<N> or Debug_<N> 1 cannot be attributed to a run. Leaked ones are cleared by the seed sweep below.
  • Seed, sweep_debug_folders(): deletes a Debug_* folder only when every process in it is a fixture-domain package and every one of those versions is older than the existing 7200s window. Any other Debug_* folder is left alone.
  • Seed, require_no_ghost_nodes(): runs registry pull --force and registry search uipath.ixp. A node matching the fixture domain raises a "tenant not ready" error. The segment after uipath.ixp. is the registry-sanitized DeploymentName, so it is matched against each live project's sanitized Name and sanitized deployment names (ixp deployments list, fixture-domain projects first, only while a node is unmatched). The Debug_ sweep stops after 120s of seed (SWEEP_BUDGET_SECONDS), and the ghost error names each node's folder key. On a candidate ghost the project list is re-read and the registry re-pulled once before raising, so a sibling that published after the first listing is not flagged. pre_run failure lands as ERROR, like preflight_connections.py. Nothing is deleted. Projects swept in the same seed are excluded from the project list, and the Debug_ sweep runs before this check, so a swept folder's node no longer trips it.
  • The e2e_04 prompt is unchanged. Whether a real debug is in scope is open.

Verify

  • cd tests/tasks/uipath-maestro-flow/ixp/e2e_03_project_creation_handoff && uv run --with pytest pytest test_handoff.py -q: 75 passed on the head; the full ixp and _shared suites pass (1942).
  • Revert-check, Debug_ sweep: removing the sweep_debug_folders() call turns test_seed_sweeps_a_stale_fixture_debug_folder_before_its_packages and test_seed_keeps_a_young_fixture_debug_folder red.
  • Revert-check, ghost guard: removing the require_no_ghost_nodes() call turns test_seed_errors_on_a_domain_node_with_no_project red.
  • Revert-check, review fixes: restoring a name-matched teardown delete turns test_teardown_leaves_every_debug_folder_alone red (sibling Debug_Proj 1 and a non-fixture Debug_Proj); removing the re-list turns test_seed_relists_projects_before_calling_a_node_a_ghost red; restoring the raw-Name ghost comparison turns 4 tests red.
  • Live on alpha with a real run (Debug_ part): uip maestro flow init plus flow debug created Debug_<project> (Type DebugSolution, under the caller's Personal Workspace). or folders list --all --name Debug_<project> returned nothing, so the code lists with plain or folders list (paged, filtered on Type and the Debug_ prefix). That folder delete was the live-verified path (now used by the seed sweep only). A rerun of a project lands in Debug_<N> 1.
  • Live on alpha codereval/DefaultTenant (ghost part): the real seed passes on a tenant with no ghost; the node/project check raises on a registry node with no project (using a non-fixture marker).

Not verified

  • Process and package removal: the minimal flow's debug left no process or package in the folder, so only the folder delete was exercised live. Process listing, package delete and ordering are covered by unit tests only.
  • The seed sweep live: no stale fixture-domain Debug_* folder exists to sweep. It sees only folders the caller can list.
  • The ghost guard against the actual Falconry ghost: the bot tenant holding it is not reachable with the available login (tenants coderevalsAH, Development, QAEnvironment, testtenant have no IXP service or no Falconry node; DefaultTenant has none).
  • The ghost stays until its folder (Debug_LicenceExpiryLog in coder-eval-bot's workspace) is deleted. The new sweep removes it only if the caller can list it and it is older than 7200s and fixture-only; otherwise the seed errors on that tenant until an owner deletes it.
  • The one-time cleanup of the 5 stuck packages is a manual admin step.
  • Coder evals not run. Would run: skill-flow-ixp-e2e-project-creation-handoff and e2e_04_build_mechanics.

Supersedes #4660.

🤖 Generated with Claude Code


Automatically cherry-picked from #4669 to release/v1.207 by @rockymadden.

…IXP node in the handoff seed (#4669)

* test(flow): fail ixp handoff seed on a domain node with no project

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

* test(flow): clean up ixp handoff Debug_ folders

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

* test(flow): fix sweep docstring

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

* test(flow): find debug folders through the plain folder listing

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

* test(flow): match ghost IXP nodes by DeploymentName and scope Debug_ teardown to new folders

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

* test(flow): leave Debug_ folders to the seed sweep and re-list projects before the ghost check

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

* test(flow): bound the Debug_ sweep and name the ghost's folder key in the seed error

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

* test(flow): re-pull the registry before judging a ghost node again

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Sonnet 5.5 <noreply@anthropic.com>

@roberts-cliff roberts-cliff left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean pick of #4669: the diff has the same patch-id as #4669, which is merged on main. Only the Socket and WIP checks ran on this bot-made PR.

@roberts-cliff roberts-cliff left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cherry-pick reviewed — diff matches source. LGTM.

@rockymadden
rockymadden merged commit 1b48836 into release/v1.207 Nov 18, 2026
8 checks passed
@rockymadden
rockymadden deleted the test-flow-ixp-cleanup-debug-folders-CP-to-release-v1-207 branch November 18, 2026 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants