Skip to content

🍒 [v1.207] test(maestro): fail Jira pre_run with a clear message when the connection is missing - #4873

Merged
rockymadden merged 1 commit into
release/v1.207from
fix-flow-jira-setup-missing-connection-CP-to-release-v1-207
Nov 18, 2026
Merged

rockymadden merged 1 commit into
release/v1.207from
fix-flow-jira-setup-missing-connection-CP-to-release-v1-207

Conversation

@github-actions

Copy link
Copy Markdown
Contributor

Failures fixed

Studio Web run 14132106, pre_run _setup/seed_jira.py crashed with a bare StopIteration for skill-flow-ipe-jira-create-issue, -ipe-jira-get-issue, -jira-lifecycle and -jira-search-triage. The bpmn jira_create_issue and jira_get_issue copies share the same bug.

Root cause

connection_id() in each task's _setup/jira_is.py ended in next(c["Id"] for c ...). With the uipath-atlassian-jira connection absent from the folder, the generator was empty and the traceback gave no hint it was a tenant problem.

Change

  • Six copies (flow: jira_create_issue, jira_get_issue, jira_lifecycle, jira_search_triage; bpmn: jira_create_issue, jira_get_issue): connection_id() raises MissingConnection naming connector, connection and folder.
  • New require_connection(), used by each seed_jira.py, exits 1 with the preflight_connections.py wording ("environment failure, not an agent failure ... Create the connection (or rename it) ..."). or folders get and connections list failures (e.g. a missing folder, 401) raise a RuntimeError with the envelope summary in all six copies..
  • MissingConnection sits after connection_id(), outside the issue-type block that test_every_jira_helper_copy_resolves_the_issue_type_the_same_way compares across copies.
  • Teardown still calls connection_id(), so its except Exception keeps swallowing the error.
  • escalation_jira_ticket copies already exit with a message; unchanged. No grading change.
  • Setup scripts run from their own _setup/ dir, so they cannot import _shared; each copy is fixed the same way.

Verify

python3 -m pytest tests/tasks/uipath-maestro-flow/e2e/test_jira_setup_missing_connection.py tests/tasks/uipath-maestro-bpmn/e2e/escalation_jira_ticket/test_jira_is.py -q (29 pass). Reverting one copy turns its cases red.

Not verified

Not run against a live tenant or in Studio Web. Open PR #4380 edits the same files; merge order may need a conflict resolution.

Out of scope: escalation_jira_ticket (flow and BPMN) seed.py still calls raw connection_id(); the six copies stay per-task by design.

🤖 Generated with Claude Code


Automatically cherry-picked from #4509 to release/v1.207 by @rockymadden.

…tion is missing (#4509)

* test(maestro-flow): fail Jira pre_run with a clear message when the connection is missing

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* test(maestro): fail Jira pre_run clearly on a missing connection in the bpmn copies too

Keep MissingConnection after connection_id() so the shared issue-type block stays identical across copies.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(tests): say environment failure in Jira setup missing-connection message

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

* fix(tests): name the fix for a missing Jira connection; surface list failures

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

* fix(tests): surface a failed Jira folder lookup

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

@roberts-cliff roberts-cliff left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean pick of #4509: the diff has the same patch-id as #4509, which is merged on main. Only the Socket and WIP checks ran on this bot-made PR.

@roberts-cliff roberts-cliff left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cherry-pick reviewed — diff matches source. LGTM.

@rockymadden
rockymadden merged commit 40fb4c7 into release/v1.207 Nov 18, 2026
8 checks passed
@rockymadden
rockymadden deleted the fix-flow-jira-setup-missing-connection-CP-to-release-v1-207 branch November 18, 2026 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants