Repository navigation
fix(uipath-solution): use actual UI label "Activate deployment" [CA-233] - #4869
Conversation
|
Claude finished @roberts-cliff's task in 31s —— View job SummarySwaps the made-up UI label "Setup activation" (from the Change-by-Change Review1.
|
| Area | Status | Notes |
|---|---|---|
| Frontmatter | OK | Not touched |
| E2E Tests | OK | No new capability; no task depends on the old label |
| Skill Body | OK | Change stays inside the flavor block; canonical block not affected |
| References & Assets | OK | Anchor link #open-the-deployment-in-orchestrator not changed |
| Repo Hygiene | OK | Limited to uipath-solution; no secrets or paths |
Issues for Manual Review
- I can't check from here that the Orchestrator button really says Activate deployment, or that clicking it opens the activation-setup wizard for a deployment in Inactive (Needs setup). Confirm against the current Orchestrator UI (the CA-233 finding suggests it does).
Conclusion
Approve. The label fix is correct and kept to these 4 lines. The only open point is the optional Low wording change in pack-and-deploy.md:167.
6f2985c to
e98c5ba
Compare
The skill said "Setup activation" — a concept derived from the NeedsSetupToActivate API status — but Orchestrator's button reads "Activate deployment". Agents relayed the wrong label; PACT golden thread caught it at step 29. Four occurrences across activate-and-manage.md, pack-and-deploy.md, and the studioweb flavor SKILL.md now say "Activate deployment" where they instruct the user to click. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013tiDkBvodTad2Je4FVfz4q
e98c5ba to
b4b2c3f
Compare
tmatup
left a comment
There was a problem hiding this comment.
Approve. No blocking issues.
I checked that no "Setup activation" string remains anywhere in skills/ or skill-flavors/ at this head (git grep -i returns nothing). I also checked that each rewrite keeps the facts around it unchanged: NeedsSetupToActivate, the 4007 refusal, the Inactive (Needs setup) UI state, and the ActivationSetup / Draft exit.
One non-blocking gap (enabling layer). The CLI itself still tells agents "Setup activation". For example, uipath-cli packages/solution-tool/src/commands/deploy-run.ts:137: Or complete 'Setup activation' for 'my-deployment' in Orchestrator .... The same wording appears in the deploy run help text and the NextSteps examples. An agent that relays NextSteps will keep using the old label, and now the skill and the CLI name the same button differently. A follow-up CLI PR that says "Activate deployment" would fix this at the source. I can file it.
Not verified: that the Orchestrator button reads exactly "Activate deployment". I took that from CA-233 and did not check the live UI.
Review run with Claude Code; each finding was reproduced with a probe at the PR head.
|
Thanks. On the non-blocker: agreed. |
rockymadden
left a comment
There was a problem hiding this comment.
🟢 Approved: No remaining findings.
What
- Uses the actual Activate deployment UI label in solution references and Studio Web guidance.
Axes
| Axis | Blockers | Non-blockers | Top finding |
|---|---|---|---|
| Correctness & logic | 0 | 0 | none |
| Code quality & simplicity | 0 | 0 | none |
| Types & contracts | 0 | 0 | none |
| Tests & validation | 0 | 0 | none |
| Security | 0 | 0 | none |
| Architecture & design | 0 | 0 | none |
| Error handling & resilience | 0 | 0 | none |
| Interface, docs & compatibility | 0 | 0 | none |
Overall findings
- None.
Validation
- Checked CA-233, the UI source and all touched canonical/flavor passages. No drift found.
- Tests and CI reviewed without local execution; current checks pass or skip.
tl;dr: The label matches the UI and both skill variants.
Summary
NeedsSetupToActivateAPI status) where the actual Orchestrator UI button is Activate deployment. Agents relayed the wrong label to users.activate-and-manage.md,pack-and-deploy.md, and the studioweb flavorSKILL.mdnow say "Activate deployment" (the button label) or "activation setup" / "activation wizard" (the concept) where appropriate.Test plan
grep -ri "Setup activation" skills/ skill-flavors/returns nothing🤖 Generated with Claude Code
https://claude.ai/code/session_013tiDkBvodTad2Je4FVfz4q