Repository navigation
fix(uipath-rules): say what rules debug uploads - #4856
Conversation
|
Claude finished @gpanaitescu's task in 29s —— View job SummaryChanges one sentence in Change-by-Change Review1.
|
| Area | Status | Notes |
|---|---|---|
| Frontmatter | OK | Untouched |
| E2E Tests | OK | Wording change only; no task asserts on it |
| Skill Body | OK | Inside the verify block; studioweb override unaffected |
| References & Assets | OK | - |
| Repo Hygiene | OK | Changes stay inside uipath-rules |
Issues for Manual Review
- Merge timing: I can't confirm that the upload set (
.uipx+ listed projects +resources/+userProfile/,.uipignorehonored) matches UiPath/cli#6153. As the PR body says, hold the merge until #6153 reaches the dev channel. Until then the new sentence describes behavior the CLI doesn't have yet.
Conclusion
No issues found. Approve once UiPath/cli#6153 is on the dev channel.
There was a problem hiding this comment.
🔵 Needs a closer look
The required dev-channel availability of UiPath/cli#6153 could not be verified because the PR returned 404, leaving a merge prerequisite for a maintainer to confirm.
No open issues 🎉
What changed in this PR
Updates the Business Rules skill’s documentation to describe the upload scope introduced by UiPath/cli#6153, rather than saying rules debug uploads the entire solution folder.
Changes:
- Specifies that uploads include the
.uipx, its listed projects,resources/, anduserProfile/, with.uipignoreapplied. - Retains the warning that debug overwrites the Studio Web solution and local users should pull remote edits first.
| File | Description |
|---|---|
skills/uipath-rules/SKILL.md |
Clarifies which solution files rules debug uploads. |
Review effort: Balanced
rockymadden
left a comment
There was a problem hiding this comment.
Recommendation: 🟢 Approved. No blockers. One non-blocker tied to UiPath/cli#6153.
What
- One sentence in
skills/uipath-rules/SKILL.md(verify block):rules debugnow says it uploads the.uipx, listed projects,resources/anduserProfile/with.uipignoreapplied, instead of "the whole solution folder".
Axes
| Axis | Blockers | Non-blockers | Top finding |
|---|---|---|---|
| Correctness & logic | 0 | 1 | claim not true for the cli fallback, SKILL.md:84 |
| Code quality & simplicity | 0 | 0 | none |
| Types & contracts | 0 | 0 | none |
| Tests & validation | 0 | 0 | none |
| Security | 0 | 0 | none |
| Architecture & design | 0 | 0 | none |
| Error handling & resilience | 0 | 0 | none |
| Interface, docs & compatibility | 0 | 0 | none |
Flavor drift: none. skill-flavors/studioweb/uipath-rules/SKILL.md replaces the whole verify block (RunProject host tool, no upload text), and the edit is inside that block. Nothing inherited disagrees.
Overall findings
- non-blocker, Correctness & logic: matches cli#6153 only for the members path. For a layout the bundler cannot take, cli#6153 still sends the whole folder. If that fallback stays, the sentence misleads an agent about what leaves the machine. Fix: re-check after cli#6153 settles; if the fallback remains, say "the solution's files (a malformed solution folder is sent whole)".
- Also: the parenthetical lists four items the agent does not act on. "the solution's own files,
.uipignoreapplied" keeps the same decision value at fewer tokens. Same finding.
Order: the body says merge after cli#6153 ships to the dev channel. Keep that.
tl;dr
- Correct for the normal path, no flavor drift.
- Revisit the wording if cli#6153 keeps the whole-folder fallback.
| ``` | ||
|
|
||
| `<TRACE_ID>` is `Data.traceId`. The trace shows which rules fired. `Data.traceId` is present only when tracing is on for the tenant (the default); without it, compare the inputs against each row by hand. `rules debug` needs the project directly inside its solution folder, as `init` creates it, and a logged-in user (`uip login`). `debug` uploads the whole solution folder and overwrites its Studio Web solution; pull Studio Web edits first. | ||
| `<TRACE_ID>` is `Data.traceId`. The trace shows which rules fired. `Data.traceId` is present only when tracing is on for the tenant (the default); without it, compare the inputs against each row by hand. `rules debug` needs the project directly inside its solution folder, as `init` creates it, and a logged-in user (`uip login`). `debug` uploads the solution (the `.uipx`, the projects it lists, `resources/` and `userProfile/`, with `.uipignore` applied) and overwrites its Studio Web solution; pull Studio Web edits first. |
There was a problem hiding this comment.
🟡 non-blocker, Correctness & logic. Accurate for a well-formed solution only; cli#6153 still uploads the whole folder for a layout the bundler cannot take (and currently includes .uipath/.auth there). Fix: shorten to "uploads the solution's own files (.uipignore applied)" and add the exception if the fallback survives.
There was a problem hiding this comment.
Done, shortened as you suggested. The fallback is gone in cli#6153 (a layout the bundler cannot take is now refused before any upload), so no exception is needed.
b6e59e8 to
8c6a19b
Compare
rules debug no longer uploads the whole solution folder. It sends the .uipx, the listed projects, resources/ and userProfile/, with .uipignore applied (UiPath/cli#6153). Co-Authored-By: Claude <noreply@anthropic.com>
8c6a19b to
e04f843
Compare
Companion to UiPath/cli#6153.
uip rules debugused to upload the whole solution folder to Studio Web. With UiPath/cli#6153 it uploads the solution's own files: the.uipx, the projects it lists,resources/anduserProfile/, with.uipignoreapplied. The skill said "uploads the whole solution folder"; this changes that one sentence inskills/uipath-rules/SKILL.md.Merge after UiPath/cli#6153 is on the dev channel.
🤖 Generated with Claude Code