Skip to content

fix(uipath-rules): say what rules debug uploads - #4856

Merged
gpanaitescu merged 2 commits into
mainfrom
fix/rules_debug_upload_wording
Nov 18, 2026
Merged

gpanaitescu merged 2 commits into
mainfrom
fix/rules_debug_upload_wording

Conversation

@gpanaitescu

Copy link
Copy Markdown
Contributor

Companion to UiPath/cli#6153.

uip rules debug used to upload the whole solution folder to Studio Web. With UiPath/cli#6153 it uploads the solution's own files: the .uipx, the projects it lists, resources/ and userProfile/, with .uipignore applied. The skill said "uploads the whole solution folder"; this changes that one sentence in skills/uipath-rules/SKILL.md.

Merge after UiPath/cli#6153 is on the dev channel.

🤖 Generated with Claude Code

@gpanaitescu
gpanaitescu requested a review from a team as a code owner November 17, 2026 13:42
@github-actions

github-actions Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Claude finished @gpanaitescu's task in 29s —— View job


Summary

Changes one sentence in skills/uipath-rules/SKILL.md so it says what uip rules debug actually uploads (the .uipx, the projects it lists, resources/ and userProfile/, with .uipignore applied) instead of "the whole solution folder". This matches UiPath/cli#6153.

Change-by-Change Review

1. skills/uipath-rules/SKILL.md:84

OK

  • Scope and wording: One sentence changed. It keeps the warning that debug overwrites the Studio Web solution and the "pull Studio Web edits first" step, which still holds because the upload replaces the remote solution. It follows the terse style rules.
  • Flavor block: The line sits inside ``. The only override, skill-flavors/studioweb/uipath-rules/SKILL.md, replaces that whole block with `RunProject` host-tool guidance and never mentions `debug`. So the studioweb flavor needs no matching edit, and its rule 6 already says `debug` is unavailable there.
  • Stale copies: No other text in skills/uipath-rules/, skill-flavors/*/uipath-rules/ or tests/tasks/uipath-rules/ mentions "whole solution", .uipignore or userProfile. Nothing else is left out of date and no task grades the old phrase.
  • Hygiene: No links, secrets or cross-skill references were added. Frontmatter is untouched.

What's Missing

Nothing identified.

Area Ratings

Area Status Notes
Frontmatter OK Untouched
E2E Tests OK Wording change only; no task asserts on it
Skill Body OK Inside the verify block; studioweb override unaffected
References & Assets OK -
Repo Hygiene OK Changes stay inside uipath-rules

Issues for Manual Review

  • Merge timing: I can't confirm that the upload set (.uipx + listed projects + resources/ + userProfile/, .uipignore honored) matches UiPath/cli#6153. As the PR body says, hold the merge until #6153 reaches the dev channel. Until then the new sentence describes behavior the CLI doesn't have yet.

Conclusion

No issues found. Approve once UiPath/cli#6153 is on the dev channel.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The required dev-channel availability of UiPath/cli#6153 could not be verified because the PR returned 404, leaving a merge prerequisite for a maintainer to confirm.

No open issues 🎉

What changed in this PR

Updates the Business Rules skill’s documentation to describe the upload scope introduced by UiPath/cli#6153, rather than saying rules debug uploads the entire solution folder.

Changes:

  • Specifies that uploads include the .uipx, its listed projects, resources/, and userProfile/, with .uipignore applied.
  • Retains the warning that debug overwrites the Studio Web solution and local users should pull remote edits first.
File Description
skills/​uipath-rules/​SKILL.md Clarifies which solution files rules debug uploads.

Review effort: Balanced

@rockymadden rockymadden left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Recommendation: 🟢 Approved. No blockers. One non-blocker tied to UiPath/cli#6153.

What

  • One sentence in skills/uipath-rules/SKILL.md (verify block): rules debug now says it uploads the .uipx, listed projects, resources/ and userProfile/ with .uipignore applied, instead of "the whole solution folder".

Axes

Axis Blockers Non-blockers Top finding
Correctness & logic 0 1 claim not true for the cli fallback, SKILL.md:84
Code quality & simplicity 0 0 none
Types & contracts 0 0 none
Tests & validation 0 0 none
Security 0 0 none
Architecture & design 0 0 none
Error handling & resilience 0 0 none
Interface, docs & compatibility 0 0 none

Flavor drift: none. skill-flavors/studioweb/uipath-rules/SKILL.md replaces the whole verify block (RunProject host tool, no upload text), and the edit is inside that block. Nothing inherited disagrees.

Overall findings

  • non-blocker, Correctness & logic: matches cli#6153 only for the members path. For a layout the bundler cannot take, cli#6153 still sends the whole folder. If that fallback stays, the sentence misleads an agent about what leaves the machine. Fix: re-check after cli#6153 settles; if the fallback remains, say "the solution's files (a malformed solution folder is sent whole)".
  • Also: the parenthetical lists four items the agent does not act on. "the solution's own files, .uipignore applied" keeps the same decision value at fewer tokens. Same finding.

Order: the body says merge after cli#6153 ships to the dev channel. Keep that.

tl;dr

  • Correct for the normal path, no flavor drift.
  • Revisit the wording if cli#6153 keeps the whole-folder fallback.

Comment thread skills/uipath-rules/SKILL.md Outdated
```

`<TRACE_ID>` is `Data.traceId`. The trace shows which rules fired. `Data.traceId` is present only when tracing is on for the tenant (the default); without it, compare the inputs against each row by hand. `rules debug` needs the project directly inside its solution folder, as `init` creates it, and a logged-in user (`uip login`). `debug` uploads the whole solution folder and overwrites its Studio Web solution; pull Studio Web edits first.
`<TRACE_ID>` is `Data.traceId`. The trace shows which rules fired. `Data.traceId` is present only when tracing is on for the tenant (the default); without it, compare the inputs against each row by hand. `rules debug` needs the project directly inside its solution folder, as `init` creates it, and a logged-in user (`uip login`). `debug` uploads the solution (the `.uipx`, the projects it lists, `resources/` and `userProfile/`, with `.uipignore` applied) and overwrites its Studio Web solution; pull Studio Web edits first.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 non-blocker, Correctness & logic. Accurate for a well-formed solution only; cli#6153 still uploads the whole folder for a layout the bundler cannot take (and currently includes .uipath/.auth there). Fix: shorten to "uploads the solution's own files (.uipignore applied)" and add the exception if the fallback survives.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, shortened as you suggested. The fallback is gone in cli#6153 (a layout the bundler cannot take is now refused before any upload), so no exception is needed.

@gpanaitescu
gpanaitescu force-pushed the fix/rules_debug_upload_wording branch from b6e59e8 to 8c6a19b Compare November 18, 2026 08:37
gpanaitescu and others added 2 commits November 18, 2026 11:56
rules debug no longer uploads the whole solution folder. It sends the
.uipx, the listed projects, resources/ and userProfile/, with .uipignore
applied (UiPath/cli#6153).

Co-Authored-By: Claude <noreply@anthropic.com>
@gpanaitescu
gpanaitescu force-pushed the fix/rules_debug_upload_wording branch from 8c6a19b to e04f843 Compare November 18, 2026 09:56
@gpanaitescu
gpanaitescu merged commit ec89cd8 into main Nov 18, 2026
47 checks passed
@gpanaitescu
gpanaitescu deleted the fix/rules_debug_upload_wording branch November 18, 2026 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants