Repository navigation
ci(skill-lint): bump the linter to skill-linter#19 and fail on new errors and warnings - #4759
Merged
Merged
Conversation
…rors and warnings Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
CarlesUIPath
requested review from
AlvinStanescu,
RaduAna-Maria,
akshaylive,
bai-uipath,
dmetzgar,
gabrielavaduva,
gozhang2,
marius-bughiu,
rockymadden,
smflorentino and
uipreliga
as code owners
November 16, 2026 11:48
Contributor
|
Claude finished @CarlesUIPath's task in 1m 17s —— View job SummaryThis PR moves the skill-lint check to skill-linter#17 ( Change-by-Change Review1.
|
| Area | Status | Notes |
|---|---|---|
| Frontmatter | OK | No skill files changed |
| E2E Tests | OK | N/A |
| Skill Body | OK | N/A |
| References & Assets | OK | All shared paths exist |
| Repo Hygiene | OK | No secrets; the pinned SHA has a PR reference; the required-check name is unchanged |
Issues for Manual Review
- From here I can't verify that the internal linter's action defaults
fail-on-findingsto true. Removing the input only makes findings fail if it does. I also can't verify that--fail-on warningexcludes shadow and report-only findings. The PR's A/B evidence (exit code 1 on the troubleshoot description test) suggests both hold. - The workflow edit needs CODEOWNERS review of
/.github/, as the Trust note in the workflow says.
Conclusion
Approve. I found no blocking issues. The only notes are Low: dead .flow-work safe paths, a broad platform override, and an optional CONTRIBUTING sentence about cross-skill links.
…er#18) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
uipreliga
approved these changes
Nov 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps the skill-lint PR check to the current linter and makes it fail on what a PR adds. Findings already on
mainstill never fail it.What
.github/workflows/skill-lint.yml427217ff(skill-linter#8) →c71f4de0(skill-linter#19).fail-on-findings: "false"is removed and--fail-on warningis added, so a new error or warning fails the check. Info and report-only (shadow) findings never fail it..skill-lint.yaml, kept in step with the linter'sexamples/uipath-skills.skill-lint.yaml:LINK-CROSS-SKILL.shared: the files platform, admin, tasks and maestro-flow offer to other skills, from the cross-skill review (skill-linter#2). Links into them become info. Case shares none since feat(uipath-maestro-case): promote the builder-SDK Case skill; Studio Web pins v1 #4529.CONTENT-CRITICAL-LATE.chars_per_token: 2.56: the same token ratioAGENT-READ-TRUNCATEDalready uses.SAFETY-DESTRUCTIVE-NO-CONFIRM:safe_paths(the skills' own working files) andsafe_commands(uip maestro flow eval … remove).UIP-REQUIRED-SECTIONSis info for uipath-platform, which keeps its hard rules as top-level sections of their own.SEC-BROAD-BASHis info: every skill that declaresallowed-toolsgrants bare Bash on purpose, and scoping it is the maintainers' security call (skill-linter#18).EVAL-GATE-BASELINE.baselines_file: tests/scripts/activation_gate.py: new rule in skill-linter#19. Warns for a skill with activation prompts but noBASELINES_PCTentry, which the requiredSkill activation gateskips. Today: activity-migrator, bundles, connector-builder, insights, process-mining, rules; test(activation): gate baselines for 6 skills the activation gate skipped #4944 adds their baselines.CONTRIBUTING.mdanddocs/REQUIRED-CHECKS.md: "phase 1" is replaced by the new behavior. The check is still not required; promoting it stays a separate step after a week or two of PRs with no false alarms.What the linter bump brings
LINK-CROSS-SKILLdeclarations (shared,dependencies).SAFETY-DESTRUCTIVE-NO-CONFIRMprecision (shadow rule).LINK-ANCHORkeeps<PLACEHOLDER>text in heading slugs, which removes false dead anchors.CONTENT-CRITICAL-LATEchecks whole sections.Full list in the linter's CHANGELOG.
How "new" is decided
The PR and its merge base are linted with the same linter and the same config (the base branch's), and only findings that are not on the merge base are reported. Findings are matched by rule, file and content key, not by line number, so:
Editing a file that already has a finding doesn't make it new. Tested on
main(a89fd49) by changing files that already had findings:api-workflow/references/troubleshooting.md(over Claude Code's read cap) and toixp/SKILL.md(over Codex's);None of these was reported.
New problems are reported and fail the check. In the same test, the troubleshoot description going over 1,024 characters (error) and losing its "UiPath" prefix (warning) were reported, with exit code 1.
Verification
With the new linter, this PR's A/B run reports 0 new findings and passes, as the check on this PR should show.
The new
.skill-lint.yamlloads. Onmain:The warnings drop because 33 declared cross-skill links become info, and platform's Critical Rules warning becomes info.
The PR comment still starts with
<!-- skill-lint pr-comment -->, and a clean run's title is still### skill-lint: no new errors or warnings, which the comment job matches.The new config is read from the base branch, so it applies from the PR after this one merges. This PR's own run uses the current config with the new linter.
Not changed
No new skill-lint errors, so nothing that refers to it breaks.🤖 Generated with Claude Code