Repository navigation
docs(uipath-maestro-flow): move existing nodes from source .layout(); stale keys warn (SDK 6.115.0) - #4725
Conversation
|
Claude finished @tmatup's task in 1m 1s —— View job PR Review: #4725
SummaryUpdates the brownfield layout guidance for builder-sdk#2037. Change-by-Change Review1.
|
| Area | Status | Notes |
|---|---|---|
| Frontmatter | OK | Not touched |
| E2E Tests | OK | No new capability that needs a task; an optional one is suggested above |
| Skill Body | OK | SKILL.md not touched |
| References & Assets | Issue | Minimum SDK version and older-SDK behaviour missing (Medium) |
| Repo Hygiene | OK | Changes stay inside the one skill; no secrets or personal paths; links resolve |
Issues for Manual Review
- Check that fix(uipath-platform): stop traces feedback e2e from timing out #2037 really applies collapsed state changes, and that a decompiled source can express collapsed state in an
at()/long-hand entry. Otherwise "position, size or collapsed state" promises something the agent can't do. - Check that an edge key matching no edge also only warns. The PR body says so, but the docs mention only node keys.
- Check that
checkreportsLAYOUT_UNKNOWN_KEYwith that exact code, since agents will grep for it.
I didn't run npm run skills:validate / skills:build myself. No flavor block content changed, so the author's runs cover it.
|
Review triage (Claude bot):
🤖 Generated with Claude Code |
8670114 to
79af089
Compare
f74f74b to
7d3d3b5
Compare
rockymadden
left a comment
There was a problem hiding this comment.
🟡 Commented: no blockers of its own. It is stacked on #4724, which has one, and builder-sdk#2037 still shows changes requested.
What
Docs for builder-sdk#2037 (open, latest review is changes requested). Merge applies a changed .layout() entry to the original node, so moving a node no longer needs a hand edit of the merged .flow. A stale key now warns LAYOUT_UNKNOWN_KEY instead of failing compile. The older-SDK fallback sits in a new layout-edit-sdk-upgrade flavor block, and the Studio Web override says to tell the user.
Axes
| Axis | Blockers | Non-blockers | Top finding |
|---|---|---|---|
| Correctness & logic | 0 | 2 | entry may not exist after a new-SDK compile skills/uipath-maestro-flow/references/brownfield.md:619 |
| Code quality & simplicity | 0 | 0 | none |
| Types & contracts | 0 | 0 | none |
| Tests & validation | 0 | 0 | none |
| Security | 0 | 0 | none |
| Architecture & design | 0 | 0 | none |
| Error handling & resilience | 0 | 0 | none |
| Interface, docs & compatibility | 0 | 2 | subflow sentence contradicts the move rule skills/uipath-maestro-flow/references/brownfield.md:624 |
Overall findings
- None beyond the inline comments.
Verified vs reasoned
- ✅ Checked at builder-sdk#2037 head
034b99dd:applyLayoutEditsruns only with a baseline, diffsposition/size/collapsed, and covers root and subflows. Every documented loop has a baseline: stamped source,--baseline, or a compiled baseline for a supplied source (brownfield.md:306). - ✅ The flavor block reads as a sentence on both sides. Studio Web's "tell the user" fits its rule never to hand-edit the merged
.flow. - ✅
LAYOUT_UNKNOWN_KEYis a warning in compile andcheck. - ❓ Not verified: whether the designer keeps
ui.placeholderon a node when it saves, which decides how often the first inline finding hits. - ❓ #2037's last fix (flag every compiled node) has not been re-reviewed. Recheck these lines if it changes.
tl;dr
Matches the SDK on the canonical path. Four small fixes: the entry may not exist, Studio Web drops moves onto grid points, the gates need version numbers, and one subflow sentence contradicts the move rule.
79af089 to
1fe4269
Compare
… kept subflow takes your changed entries Review on #4725: decompile writes no .layout() entry for a node compile placed, so the move instruction says change or add the entry; and a subflow kept from the original still takes the entries you changed. 🤖 Generated with Claude Code Co-Authored-By: [Claude](mailto:noreply@anthropic.com)
7d3d3b5 to
c29044a
Compare
rockymadden
left a comment
There was a problem hiding this comment.
Recommendation: 🟢 Approved. Three of four non-blockers are fixed at c29044ad; one stands.
Fixed
- ✅ 🟡 "Change its entry" assumed one exists: now "change or add its entry … decompile writes none for a node compile placed and nobody moved since".
- ✅ 🟡 Studio Web move onto a grid point dropped: builder-sdk#2036 marks every compiled node, and #2037 (
f35b1b6c) passes the sameunplacedRuletoapplyLayoutEdits(merge.ts:603-614), so the move lands. - ✅ 🟡 "Any other subflow keeps the original" contradicted the move rule: now "plus the entries you changed".
Still open
- 🟡 PR-number gates:
brownfield.md:625and:633,diagnose.md:135,operate.md:81say "builder-sdk#2037". Inline.
New: none. layout-edit-sdk-upgrade has its Studio Web override; LAYOUT_UNKNOWN_KEY as a warning matches serialize.ts at #2037's head.
Axes
| Axis | Blockers | Non-blockers | Top finding |
|---|---|---|---|
| Correctness & logic | 0 | 0 | none |
| Code quality & simplicity | 0 | 0 | none |
| Types & contracts | 0 | 0 | none |
| Tests & validation | 0 | 0 | none |
| Security | 0 | 0 | none |
| Architecture & design | 0 | 0 | none |
| Error handling & resilience | 0 | 0 | none |
| Interface, docs & compatibility | 0 | 1 | PR-number SDK gate skills/uipath-maestro-flow/references/brownfield.md:625 |
Not verified: I read the SDK heads, didn't run a merge.
tl;dr
- Fixed except the PR-number gates. Swap them for the release version, then merge after #2037 ships.
1fe4269 to
d852b78
Compare
… kept subflow takes your changed entries Review on #4725: decompile writes no .layout() entry for a node compile placed, so the move instruction says change or add the entry; and a subflow kept from the original still takes the entries you changed. 🤖 Generated with Claude Code Co-Authored-By: [Claude](mailto:noreply@anthropic.com)
c29044a to
63152e3
Compare
d852b78 to
54d3b23
Compare
… kept subflow takes your changed entries Review on #4725: decompile writes no .layout() entry for a node compile placed, so the move instruction says change or add the entry; and a subflow kept from the original still takes the entries you changed. 🤖 Generated with Claude Code Co-Authored-By: [Claude](mailto:noreply@anthropic.com)
b85f348 to
ba46c05
Compare
54d3b23 to
43aed58
Compare
… stale keys warn Replayed onto the rebased #4724 (builder-sdk#2037), with the older-SDK fallback. 🤖 Generated with Claude Code Co-Authored-By: [Claude](mailto:noreply@anthropic.com)
… kept subflow takes your changed entries Review on #4725: decompile writes no .layout() entry for a node compile placed, so the move instruction says change or add the entry; and a subflow kept from the original still takes the entries you changed. 🤖 Generated with Claude Code Co-Authored-By: [Claude](mailto:noreply@anthropic.com)
…the whole scope is compile's Matches builder-sdk#2035 e7ef8e63e: once any node of a laid-out flow or subflow is moved, decompile writes every node's entry. 🤖 Generated with Claude Code Co-Authored-By: [Claude](mailto:noreply@anthropic.com)
…dits (6.115.0) builder-sdk#2037 shipped in @uipath/maestro-builder-sdk 6.115.0. The Studio Web override tells the user the version. 🤖 Generated with Claude Code Co-Authored-By: [Claude](mailto:noreply@anthropic.com)
ba46c05 to
23255ec
Compare
Lands after #4724 (stacked on it, which lands after #4723; same
brownfield.mdanddiagnose.mdpassages).The SDK change shipped: UiPath/builder-sdk#2037 is in
@uipath/maestro-builder-sdk6.115.0, and the docs name that version as the floor.Short version
Two layout edits no longer need a hand edit of the merged
.flow(UiPath/builder-sdk#2037):mergeapplies a changed.layout()entry (position, size or collapsed state differing from the baseline) to the original node, at the root and in subflows. Example:review: at(640, 144)changed toat(640, 304)moves onlyreview.compiledrops a.layout()key that names no step (or an edge key matching no edge) with aLAYOUT_UNKNOWN_KEYwarning instead of refusing.checkreports the same warning.What text is retired, and why
references/brownfield.md: "Only an added step's entry lands" and "moving or resizing one in the source does nothing, so ... setlayout.nodes.<id>.positionor.sizein the merged.flow" replaced with: change the entry in the source and merge. The subflow sentence now says a kept subflow also takes its changed entries (thesubflow-layout-sdk-upgradeflavor block is unchanged). "A step the edit removes must lose its entry, or compile fails on the unknown key" now says the leftover key is dropped with a warning.references/operate.mdrule 3: "an unknown key failscompile" becomes "is dropped with aLAYOUT_UNKNOWN_KEYwarning".references/diagnose.md"Misshapen nodes": "In a merged brownfield file only an added node's entry lands; fix ... in the merged.flow'slayout.nodes" becomes: fix it in the decompiled source and merge again.No flavor block content changed; the Studio Web overrides already say never to edit the merged
.flow.Checks run
npm run skills:validate,npm run skills:check-links,git diff --check.🤖 Generated with Claude Code
Co-Authored-By: Claude