Repository navigation
docs(uipath-maestro-flow): drop the format step now that compile lays out (SDK 6.113.0) - #4723
Conversation
|
Claude finished @tmatup's task in 1m 8s —— View job SummaryThe PR removes the Change-by-Change Review1.
|
| Area | Status | Notes |
|---|---|---|
| Frontmatter | OK | Unchanged |
| E2E Tests | OK | No task depends on the removed step; a coverage check is optional |
| Skill Body | OK | One lifecycle line removed |
| References & Assets | Issue | No SDK version gate for compile's layout (#1, #2) |
| Repo Hygiene | OK | Scoped to one skill and its overrides; no secrets or personal paths |
Issues for Manual Review
- Check the canvas sizes against builder-sdk#2035: container 560 × 320, agent 288 × 96 (
inlineAgent,conversationalAgent,voiceAgent), every other node 96 × 96. Also check whether other node kinds have their own shape sizes. - Check that a
.layout()that leaves out some nodes still puts those nodes on the placeholder row, not at auto-layout positions, as rule 3 still says. - Studio Web's bundled SDK must be at the fix(skills): route diagnostic intent to uipath-troubleshoot before platform work (cherry-pick #1980 to v1.197) #2035 release before this merges, as the PR body says.
Conclusion
The change is correct for the target SDK and well scoped. Before merge I'd ask for one change: name the minimum SDK version for compile's layout and keep the format fallback for older SDKs (#1/#2). Without it, an agent on an older SDK silently ships flat-row layouts.
|
Review triage (Claude bot):
🤖 Generated with Claude Code |
0a8b667 to
d46aca1
Compare
…eep the grid caveat for an older SDK Replayed onto the rebased #4723: drops the placeholder-grid warning for at() in brownfield (builder-sdk#2036), with the older-SDK fallback. 🤖 Generated with Claude Code Co-Authored-By: [Claude](mailto:noreply@anthropic.com)
There was a problem hiding this comment.
🟡 Commented: 1 blocker. The Studio Web new-flow loop still compiles a flat row, and this PR removes its format.
What
Docs for builder-sdk#2035 (still open, latest review is changes requested). compile now lays out a source with no .layout() as format does, and sizes nodes by shape. The PR drops the post-compile format step and the hand dim(288, 96) from the canonical skill and the Studio Web flavor, and keeps "never format a merged file".
Axes
| Axis | Blockers | Non-blockers | Top finding |
|---|---|---|---|
| Correctness & logic | 1 | 0 | Studio Web new flow keeps the placeholder row skill-flavors/studioweb/uipath-maestro-flow/SKILL.md:98 |
| Code quality & simplicity | 0 | 1 | lines that change nothing skills/uipath-maestro-flow/references/operate.md:18 |
| Types & contracts | 0 | 0 | none |
| Tests & validation | 0 | 1 | no eval checks a greenfield compile lands laid out |
| Security | 0 | 0 | none |
| Architecture & design | 0 | 0 | none |
| Error handling & resilience | 0 | 0 | none |
| Interface, docs & compatibility | 0 | 1 | SDK gate names a PR, not a version skills/uipath-maestro-flow/references/operate.md:33 |
Overall findings
- 🟡 non-blocker · Tests & validation: no coder eval task checks that a greenfield compile lands laid out without
format. A Studio Web case starting from a decompilednew.flowwould have caught the blocker. Fix: add one advisory task that greps the compiled.flowfor distinctyvalues.
Verified vs reasoned
- ✅ Checked against builder-sdk#2035 head
445a83af: shape sizes (container 560 × 320,rectangle288 × 96, else 96 × 96), origin (256, 144). All three agent types (uipath.agent.autonomous,.conversational,.voice) userectangle. A scope with any author entry keeps the placeholder row. - ✅ Grep found no leftover
lay-out-the-emitted-flow-firstanchor,dim(288rule, or post-compileformatstep.operate.md:43-46(nodes createwithout--position, thenformat) is a separate CLI path and stays valid. - ✅ Every canonical change sits inside a flavor block that the Studio Web override replaces, or is inherited text that reads correctly with the override's wording.
- ❓ Not verified: the Studio Web canvas's
new.flow(trigger position). That is why the blocker is reasoned. - ❓ #2035's last two fixes (flagging every compiled node
ui.placeholder: true) have not been re-reviewed. Recheck these docs if that thread changes behavior again.
tl;dr
The canonical docs match the SDK. In Studio Web a new flow starts from a decompiled new.flow, so its trigger entry turns off auto-layout and the flow compiles flat. This PR removes the format that fixed that.
… out compile now lays out a flow or subflow with no .layout() the way `uip maestro flow format` does, and sizes every node by its canvas shape (UiPath/builder-sdk#2035). Retire the "run format on greenfield" step, the hand dim(288, 96) for agents, and dim() for default-size containers. Keep "never format a merged brownfield file". Studio Web overrides updated to match. 🤖 Generated with Claude Code Co-Authored-By: [Claude](mailto:noreply@anthropic.com)
Address review: state that compile layout needs an SDK with builder-sdk#2035, and keep the format / dim() fallback for an older SDK, with an upgrade flavor block (Studio Web: tell the user). 🤖 Generated with Claude Code Co-Authored-By: [Claude](mailto:noreply@anthropic.com)
…ly .layout() before compile Review on #4723: the Studio Web new-flow loop starts from a decompiled new.flow, whose .layout() names the canvas trigger, so compile kept every added step on the placeholder row. The loop and the operate-format override now say to delete that call first. Also trims two operate.md lines that changed nothing. 🤖 Generated with Claude Code Co-Authored-By: [Claude](mailto:noreply@anthropic.com)
d46aca1 to
f57a2c3
Compare
…eep the grid caveat for an older SDK Replayed onto the rebased #4723 (builder-sdk#2036), with the older-SDK fallback. 🤖 Generated with Claude Code Co-Authored-By: [Claude](mailto:noreply@anthropic.com)
rockymadden
left a comment
There was a problem hiding this comment.
Recommendation: 🟢 Approved. The blocker and one non-blocker are fixed at f57a2c30; two non-blockers stand.
Fixed
- ✅ 🔴 Studio Web new flow compiled flat: the loop now deletes the decompiled
new.flow's trigger-only.layout()before compile (skill-flavors/studioweb/uipath-maestro-flow/SKILL.md:96), and theoperate-formatoverride says why. Matches builder-sdk#2035/#2036: a scope with any entry keeps the placeholder row. - ✅ 🟡 Sentences that changed nothing in
operate.md: dropped; what's left ends in "skip it".
Still open
- 🟡 PR-number gate:
operate.md:31,diagnose.md:127and the flavor'sdiagnose.md:35say "builder-sdk#2035". Inline. - 🟡 Overall · Tests & validation: no eval checks that a greenfield compile lands laid out without
format. Fix: one advisory task that checks the compiled.flowhas more than one distincty.
New: none. The new compile-layout-sdk-upgrade block has its Studio Web override, so no flavor drift.
Axes
| Axis | Blockers | Non-blockers | Top finding |
|---|---|---|---|
| Correctness & logic | 0 | 0 | none |
| Code quality & simplicity | 0 | 0 | none |
| Types & contracts | 0 | 0 | none |
| Tests & validation | 0 | 1 | no eval for greenfield layout |
| Security | 0 | 0 | none |
| Architecture & design | 0 | 0 | none |
| Error handling & resilience | 0 | 0 | none |
| Interface, docs & compatibility | 0 | 1 | PR-number SDK gate skills/uipath-maestro-flow/references/operate.md:31 |
Not verified: a real Studio Web new.flow; I read the SDK heads, didn't run anything.
tl;dr
- Blocker fixed. Swap the PR number for the release version when #2035 ships, then merge.
…de its size budget 🤖 Generated with Claude Code Co-Authored-By: [Claude](mailto:noreply@anthropic.com)
…eep the grid caveat for an older SDK Replayed onto the rebased #4723 (builder-sdk#2036), with the older-SDK fallback. 🤖 Generated with Claude Code Co-Authored-By: [Claude](mailto:noreply@anthropic.com)
… output (6.113.0) builder-sdk#2035 shipped in @uipath/maestro-builder-sdk 6.113.0, so the gates name that version instead of the PR. The Studio Web override tells the user the version rather than installing it. 🤖 Generated with Claude Code Co-Authored-By: [Claude](mailto:noreply@anthropic.com)
…eep the grid caveat for an older SDK Replayed onto the rebased #4723 (builder-sdk#2036), with the older-SDK fallback. 🤖 Generated with Claude Code Co-Authored-By: [Claude](mailto:noreply@anthropic.com)
…eep the grid caveat for an older SDK Replayed onto the rebased #4723 (builder-sdk#2036), with the older-SDK fallback. 🤖 Generated with Claude Code Co-Authored-By: [Claude](mailto:noreply@anthropic.com)
… (SDK 6.114.0) (#4724) * docs(uipath-maestro-flow): merge places only nodes compile flagged; keep the grid caveat for an older SDK Replayed onto the rebased #4723 (builder-sdk#2036), with the older-SDK fallback. 🤖 Generated with Claude Code Co-Authored-By: [Claude](mailto:noreply@anthropic.com) * docs(uipath-maestro-flow): name the SDK release that marks compile-placed nodes (6.114.0) builder-sdk#2036 shipped in @uipath/maestro-builder-sdk 6.114.0. The Studio Web override tells the user the version. 🤖 Generated with Claude Code Co-Authored-By: [Claude](mailto:noreply@anthropic.com)
The SDK change shipped: UiPath/builder-sdk#2035 is in
@uipath/maestro-builder-sdk6.113.0, and the docs name that version as the floor.Short version
compilenow lays out a flow with no.layout()exactly asuip maestro flow formatdoes, and gives every node its canvas-shape size (UiPath/builder-sdk#2035). So the skill no longer needs to tell agents to runformataftercompile, or to hand-size agent nodes withdim(288, 96).Example:
at(1312, 144)on an inline agent now compiles to 288 x 96; before, it compiled to 96 x 96 unless writtenat(1312, 144, dim(288, 96)).What text is retired, and why
SKILL.mdLifecycle: the "Greenfield only ...flow format" step aftercompile.formaton a compiled file now moves nothing.references/CLI-LOOP.md: the paragraph saying to runformaton a greenfield file before upload/debug/designer.references/operate.md"Lay out the emitted flow first" (renamed Layout of the emitted flow): replaced theformatinstruction and the "one flat placeholder row" explanation with what compile now does (positions asformat, sizes: container 560 x 320, agent 288 x 96, else 96 x 96). Kept "never format a merged brownfield file":formatstill discards author positions.operate.md.layout()rules: dropped handdim(288, 96)for agents anddim()for default-size containers; a container bigger than 560 x 320 still needsdim(). Rule 3 (name every node or none) stays: a partial.layout()still leaves unnamed nodes on compile's placeholder row.references/diagnose.md"Misshapen nodes": removed theformatfix and the "agent withoutdim(288, 96)" cause.extract-document-node.md: two anchor links updated for the renamed heading.Flavor overrides
skill-flavors/studioweb/uipath-maestro-flow/overrides for the changed blocks (sdk-lifecycle,local-gates,operate-format,misshapen-format) updated the same way: the new-flow loop dropsformat; "never format a merged file" stays. Studio Web needs its SDK copy at the release that ships #2035.Checks run
npm run skills:validate,npm run skills:check-links,npm run skills:build,git diff --check.🤖 Generated with Claude Code
Co-Authored-By: Claude