Skip to content

docs(uipath-maestro-bpmn): match the cli case rules evaluator and guardrails contracts - #4622

Open
vlad-uipath wants to merge 2 commits into
mainfrom
docs/maestro-bpmn-case-decision-contracts
Open

vlad-uipath wants to merge 2 commits into
mainfrom
docs/maestro-bpmn-case-decision-contracts

Conversation

@vlad-uipath

@vlad-uipath vlad-uipath commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

Brings the classic BPMN skill in line with the contracts in https://github.com/UiPath/cli/pull/5957, which now follow what Studio Web's case converter saves. The skill still said the case rules evaluator sits on a service task.

  • references/registry-workflow.md: Maestro.CaseRulesEvaluator → bpmn:task, Maestro.CaseManagerGuardrails stays bpmn:serviceTask. Adds a short note on both contracts: inputs merged into one target="body" input (not uipath:context), the evaluator output caseRulesDecisions/json/=result, and the guardrails output rule (picked by source="=result", named caseManagerDecisions or schedulerOutput, type not checked, var equal to the variable the decisions input reads).
  • validator/bpmn-spec.json: the file is hand-maintained (no sync script), so the two entries are copied from cli main's packages/maestro-sdk/src/manifest/bpmn-spec.json (as merged in #5957) with a script that keeps the file's formatting, and the top-level source notes the cli PR. Both entries are now byte-identical to cli main. For the guardrails entry that means no outputType (the type is not pinned, matching "type not checked" above), plus outputNames, outputVarFromInputField: "decisions" and regenerateInstruction.

Ran npm run skills:validate, npm run skills:check-links, and the spec-reading guards tests/scripts/test_bpmn_connector_request_contract.py and test_bpmn_script_task_contract.py (6 passed). Checked both entries against cli origin/main with jq + diff (no difference).

🤖 Generated with Claude Code

…tch the cli case decision contracts

UiPath/cli#5957 changes the Maestro.CaseRulesEvaluator and
Maestro.CaseManagerGuardrails contracts to what Studio Web's case converter
saves. Update the classic skill's host-element table and validator spec to match.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@vlad-uipath
vlad-uipath requested a review from a team as a code owner November 11, 2026 06:36
@github-actions

github-actions Bot commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

Claude finished @vlad-uipath's task in 1m 10s —— View job


Summary

Updates the classic uipath-maestro-bpmn skill so the two case decision types match UiPath/cli#5957 and what Studio Web saves. Maestro.CaseRulesEvaluator now sits on bpmn:task, and both types use a merged target="body" input with a source="=result" output.

Change-by-Change Review

1. classic/skills/uipath-maestro-bpmn/references/registry-workflow.md:770-792

OK

  • I checked the change against the Studio Web–saved fixture tests/tasks/uipath-maestro-case/edit/designer_saved_plan/fixtures/.../caseplan.case.bpmn:355-402. The new prose matches it:
    • The evaluator is a <bpmn:task> with merged caseManagerInput and output caseRulesDecisions, type="json", source="=result", custom="true".
    • Guardrails is a <bpmn:serviceTask> with a merged body containing decisions and caseCurrentExecutionState. Its output caseManagerDecisions uses source="=result", and var="caseManagerDecisions" equals the variable decisions reads (=js:vars.caseManagerDecisions).
  • The existing body-target list at :327-330 still holds, since both types keep inputTarget: body.
  • Low: "Inputs … not in uipath:context" is correct for inputs. However, the saved file still has a <uipath:context><uipath:inputSchema …/></uipath:context> block on both nodes (caseplan.case.bpmn:359-361, 393-395). The new xmlTemplates leave it out. An agent reading "not in uipath:context" might delete an existing inputSchema when editing. Consider adding "(the uipath:context inputSchema Studio Web writes is preserved as-is)".
  • Low: The absolute cut-off date "Guardrails saved before 2026-08-25" will go stale (content-quality.md § What NOT to Include). The re-save instruction is the part an agent can act on. Consider "older Studio Web saves" or citing PO.Frontend #6783 as the JSON inputNotes does.

2. classic/skills/uipath-maestro-bpmn/validator/bpmn-spec.json

OK

  • bpmnElement and xmlTemplate are fixed: bpmn:Task / <bpmn:task> for the evaluator, and lowercase <bpmn:serviceTask> for guardrails. The old templates used the invalid capitalized <bpmn:ServiceTask>, and that is now gone.
  • contextFields → [] with fields moved to inputFields (each target: "body") matches the shape other mergedBody entries use (36 inputFields / contractOutputMayBeCustom / useRelativeSource occurrences in the file, so the keys are in use elsewhere).
  • Dropping useRelativeSource is consistent with the new outputSource: "=result".
  • Removing the synthetic _label context field matches the saved shape.
  • The outputNotes rule (selected by source, name either caseManagerDecisions or schedulerOutput, type unpinned, var must equal the decisions variable) matches the Markdown text, and the two don't contradict each other.
  • I could not run json.tool or the pytest guards here because of sandbox permission limits. The PR body reports they pass, and the diff looks well-formed.

What's Missing

  • Medium: tests/tasks/uipath-maestro-bpmn/nodes/contract_variant_wrappers.yaml:52 and _shared/check_contract_variant_wrappers.py:99 still require Maestro.CaseRulesEvaluator on a bpmn:serviceTask. Once this merges, the classic skill and its own eval disagree. The task prompt names the host explicitly, so the eval will keep passing, but it now grades a shape the skill says Studio Web never produces. The PR body acknowledges this and defers it to the eval owners. Please open a tracking issue so it isn't lost. Fix this →
  • The v2 skill skills/uipath-maestro-bpmn/ has no mention of these two types, so it needs no parallel change.

Area Ratings

Area Status Notes
Frontmatter OK Untouched
E2E Tests Issue contract_variant_wrappers still uses the old evaluator host (deferred)
Skill Body OK Untouched
References & Assets OK Matches the saved fixture; two Low wording notes
Repo Hygiene OK Scoped to one skill; no secrets or personal paths; links unchanged

Issues for Manual Review

  • I could not inspect UiPath/cli#5957 from here, so I did not verify that the copied bpmn-spec.json entries are byte-identical to packages/maestro-sdk/src/manifest/bpmn-spec.json in that PR.
  • The guardrails output's accepted alternate name schedulerOutput comes from the cli validator. No fixture in this repo shows it.

Conclusion

Approve with minor notes. The content is correct against a real Studio Web save, and the JSON entries are consistent with the prose. Track the deferred eval update. The two Low wording tweaks are optional.
· Branch

…i main

cli #5957 merged without outputType and with outputNames,
outputVarFromInputField and regenerateInstruction on
Maestro.CaseManagerGuardrails; the classic spec still had the earlier
draft.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant