Repository navigation
Conversation
Author
|
Native CI is failing before compilation/tests because this PR comes from my fork and cannot access the credentials needed to fetch private dependencies. |
Author
|
Replaced by #195 with the same commits on a branch in this repository so CI can access the private dependency credentials. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mainnet already rejects Lightning API calls after #177, but still initializes the Lightning runtime. This change prevents LDK runtime construction, startup and resume on mainnet while keeping the Bitcoin/RGB wallet and required shared services available.
Changes
LightningUnsupportedOnMainnetAPI error. Remove this branch'sMainnetLightningStaterefusal and mainnet-only constructor preload prerequisite. Update API/binding documentation and add persistence, upgrade and lifecycle regressions.Non-mainnet Lightning retains its existing startup/networking paths. Shared storage and lifecycle changes are covered by targeted regressions. Dependency pins, signer policies and on-chain algorithms are unchanged; no wallet migration or new operating mode is introduced.
Rollout assumption and effects
The supported mainnet rollout is assumed to have no unresolved historical Lightning obligations: channels, funding, HTLCs, claims, sweeps or RGB Lightning obligations. The team must confirm this before rollout. No current Lightning users or payments, by itself, does not establish that condition.
Successful unlock does not verify this assumption or inspect every remote store, device or browser tab. Existing records are preserved but are not decoded, replayed, migrated, monitored or recovered. A wallet with unresolved obligations needs a separately reviewed recovery path before using this release. This release does not provide one.
Observable shared API behavior:
networkInfo*returnsNetworkInfoUnavailablewithout a Lightning chain driver.pending_kv_writescounts active common-configuration retries, excluding preserved historical Lightning intents.init/unlockstill preload persistent state, but Lightning cache hydration is deferred until a permitted consumer reads it. Direct mainnet node construction and wallet attachment need no prior Lightning-state preload.Future mainnet Lightning enablement must separately validate authoritative state restoration, ownership, channel monitoring, dependency/storage compatibility and downgrade handling before accepting Lightning activity. Preserving records now does not guarantee future recovery or make that later release a flag-only change.
Verification
Local verification for the changes through
c7f118e:ee855aa, started/stopped an unfunded on-chain mainnet wallet, then opened the identical wallet with the new daemon. Real manager, graph, scorer and replay-marker records remained byte-identical; address/identity persisted and the configured peer port could remain occupied.Independent native/browser reviews found and addressed a passive supported-network event-history regression and added failed-startup preservation coverage. No unresolved blocking finding remains in those reviews under the rollout assumption.
Strict WASM Clippy still reports two unchanged upstream expressions (
needless_update,unnecessary_sort_by). Full WASM formatting has the previously recorded unchangedlib.rsdifferences. They were not changed or suppressed. One new native test's address-reuse expectation and one test-helper compile path were corrected. A C ABI unit build reported cross-crate type mismatches after shared-target reuse; rebuilding the parent package cache resolved them without source or dependency changes.These are local, unfunded fixtures, not funded-mainnet spending or historical-channel recovery. Current PR CI is blocked: 31 inspected jobs across five workflows failed authenticating to the existing
rgb-consensus-s-bfadependency before project compilation/tests. A maintainer needs to restore the workflow dependency access and rerun CI; no dependency pins or credential configuration were changed in this revision. The WASM package job was still running at the final readback. Final release packaging remains separate. The earlier October 2 Regtest SDK run was 11 passes and two reverse-payment failures; both later passed with local-only channel-capacity waits. One failure reproduced on upstream product code; the other did not in three bounded upstream attempts, so a scheduling effect was not ruled out. Those adapted results are not a clean unmodified-fixture or full SDK-suite pass.Target is
dev. The branch is based onee855aa; upstreamdevremainse2b39d5, adding release credentials and a logging lint correction. The upstream merged tree has not been executed in this verification.