Make RGB channel funding restart-safe

.github/workflows/build.yaml

@@ -16,8 +16,13 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        toolchain: [ nightly, stable, 1.88.0 ]
+        toolchain: [ stable, 1.94.0, beta ]
         name: [ linux, windows, macos ]
+        exclude:
+          - name: windows
+            toolchain: beta
+          - name: macos
+            toolchain: beta
         include:
           - name: linux
             os: warp-ubuntu-latest-x64-16x

.github/workflows/format.yaml

@@ -22,3 +22,8 @@ jobs:
           components: rustfmt
       - name: Format
         run: cargo fmt -- --check
+      # these crates have their own workspace, so the root `cargo fmt` skips them
+      - name: Format (out-of-workspace binding crates)
+        run: |
+          cargo fmt --manifest-path bindings/c-ffi/Cargo.toml -- --check
+          cargo fmt --manifest-path bindings/uniffi-bindgen/Cargo.toml -- --check

.github/workflows/release-sdk.yaml

@@ -69,7 +69,7 @@ jobs:
       - name: Setup Rust
         uses: actions-rust-lang/setup-rust-toolchain@v1
         with:
-          toolchain: 1.88.0
+          toolchain: 1.94.0
           rustflags: ""
 
       - name: Add wasm32 target
@@ -133,7 +133,7 @@ jobs:
       - name: Setup Rust
         uses: actions-rust-lang/setup-rust-toolchain@v1
         with:
-          toolchain: 1.88.0
+          toolchain: 1.94.0
           rustflags: ""
 
       - name: Setup Java
@@ -275,7 +275,7 @@ jobs:
       - name: Setup Rust
         uses: actions-rust-lang/setup-rust-toolchain@v1
         with:
-          toolchain: 1.88.0
+          toolchain: 1.94.0
           rustflags: ""
 
       - name: Install bindgen-cli

.github/workflows/sdk-e2e.yaml

@@ -24,7 +24,7 @@ jobs:
       - name: Setup Rust
         uses: actions-rust-lang/setup-rust-toolchain@v1
         with:
-          toolchain: 1.88.0
+          toolchain: 1.94.0
           rustflags: ""
 
       - name: Cache Rust build artifacts
@@ -136,7 +136,7 @@ jobs:
       - name: Setup Rust
         uses: actions-rust-lang/setup-rust-toolchain@v1
         with:
-          toolchain: 1.88.0
+          toolchain: 1.94.0
           rustflags: ""
 
       - name: Cache Rust build artifacts
@@ -173,7 +173,7 @@ jobs:
       - name: Setup Rust
         uses: actions-rust-lang/setup-rust-toolchain@v1
         with:
-          toolchain: 1.88.0
+          toolchain: 1.94.0
           rustflags: ""
 
       - name: Cache Rust build artifacts
@@ -210,7 +210,7 @@ jobs:
       - name: Setup Rust
         uses: actions-rust-lang/setup-rust-toolchain@v1
         with:
-          toolchain: 1.88.0
+          toolchain: 1.94.0
           rustflags: ""
 
       - name: Cache Rust build artifacts
@@ -247,7 +247,7 @@ jobs:
       - name: Setup Rust
         uses: actions-rust-lang/setup-rust-toolchain@v1
         with:
-          toolchain: 1.88.0
+          toolchain: 1.94.0
           rustflags: ""
 
       - name: Cache Rust build artifacts
@@ -355,7 +355,7 @@ jobs:
       - name: Setup Rust
         uses: actions-rust-lang/setup-rust-toolchain@v1
         with:
-          toolchain: 1.88.0
+          toolchain: 1.94.0
           rustflags: ""
 
       - name: Cache Rust build artifacts
@@ -419,7 +419,7 @@ jobs:
       - name: Setup Rust
         uses: actions-rust-lang/setup-rust-toolchain@v1
         with:
-          toolchain: 1.88.0
+          toolchain: 1.94.0
           rustflags: ""
 
       - name: Cache Rust build artifacts
@@ -592,7 +592,7 @@ jobs:
       - name: Setup Rust
         uses: actions-rust-lang/setup-rust-toolchain@v1
         with:
-          toolchain: 1.88.0
+          toolchain: 1.94.0
           rustflags: ""
 
       - name: Cache Rust build artifacts
@@ -633,7 +633,7 @@ jobs:
       - name: Setup Rust
         uses: actions-rust-lang/setup-rust-toolchain@v1
         with:
-          toolchain: 1.88.0
+          toolchain: 1.94.0
           rustflags: ""
 
       - name: Cache Rust build artifacts

.github/workflows/test.yaml

@@ -77,7 +77,7 @@ jobs:
           cargo test --features "uniffi,vls" --lib 'signer::channel_signer::tests::' -- --test-threads=1
           cargo test --features "uniffi,vls" --lib 'signer::in_process_transport::tests::' -- --test-threads=1
 
-  test:
+  test_and_coverage:
     runs-on: warp-ubuntu-latest-x64-16x
     timeout-minutes: 90
     steps:
@@ -86,9 +86,26 @@ jobs:
           submodules: true
       - uses: actions-rust-lang/setup-rust-toolchain@v1
         with:
+          components: llvm-tools-preview
+          toolchain: stable
           rustflags: ""
-      - name: Tests
-        run: cargo test -- --test-threads=1 --skip test::gossip_
+      - name: Build daemon binary for process-crash tests
+        run: cargo build --bin rgb-lightning-node
+      - name: Install llvm-cov
+        env:
+          LLVM_COV_RELEASES: https://github.com/taiki-e/cargo-llvm-cov/releases
+        run: |
+          host=$(rustc -Vv | grep host | sed 's/host: //')
+          curl -fsSL $LLVM_COV_RELEASES/latest/download/cargo-llvm-cov-$host.tar.gz | tar xzf - -C "$HOME/.cargo/bin"
+      - name: Tests and coverage report
+        run: ./coverage.sh --ci --skip test::gossip_
+      - name: Upload coverage report
+        uses: codecov/codecov-action@v6
+        with:
+          fail_ci_if_error: false
+          file: coverage.lcov
+          flags: rust
+          token: ${{ secrets.CODECOV_TOKEN }}
       - name: UniFFI SDK smoke tests
         run: cargo test --features uniffi --lib 'uniffi_smoke_tests::' -- --test-threads=1
 
@@ -141,8 +158,15 @@ jobs:
         run: cargo build --features vss
       - name: Run deterministic VSS durability regressions
         run: cargo test --features vss "test::vss_durability_gaps" -- --test-threads=1
+      - name: Run VSS teardown headline tests
+        run: cargo test --features "uniffi,test-utils,vls,vss" --bin rgb-lightning-node ldk::vss_teardown_tests -- --test-threads=1
       - name: Start regtest and VSS services
         run: VSS=1 ./regtest.sh start
+      - name: Run RGB channel-info device-loss durability regression
+        run: >-
+          cargo test --features vss
+          "test::vss_durability_gaps::tests::acknowledged_rgb_channel_info"
+          -- --test-threads=1
       - name: Run VSS tests (e2e against regtest + VSS server)
         run: SKIP_INIT=1 cargo test --features vss "test::vss::tests" -- --test-threads=1
       - name: Run VSS unreachable openchannel e2e test

.github/workflows/uniffi-artifacts.yaml

@@ -24,7 +24,7 @@ jobs:
       - name: Setup Rust
         uses: actions-rust-lang/setup-rust-toolchain@v1
         with:
-          toolchain: 1.88.0
+          toolchain: 1.94.0
           rustflags: ""
 
       - name: Run library-only test suite
@@ -43,7 +43,7 @@ jobs:
       - name: Setup Rust
         uses: actions-rust-lang/setup-rust-toolchain@v1
         with:
-          toolchain: 1.88.0
+          toolchain: 1.94.0
           rustflags: ""
 
       - name: Build host cdylib
@@ -77,7 +77,7 @@ jobs:
       - name: Setup Rust
         uses: actions-rust-lang/setup-rust-toolchain@v1
         with:
-          toolchain: 1.88.0
+          toolchain: 1.94.0
           rustflags: ""
 
       - name: Setup Java
@@ -169,7 +169,7 @@ jobs:
       - name: Setup Rust
         uses: actions-rust-lang/setup-rust-toolchain@v1
         with:
-          toolchain: 1.88.0
+          toolchain: 1.94.0
           rustflags: ""
 
       - name: Install bindgen-cli

.gitignore

@@ -1,5 +1,6 @@
 # Test files
 /datacore
+/dataesplora
 /dataindex
 /dataldk0
 /dataldk1
@@ -10,6 +11,9 @@
 # will have compiled files and executables
 **/target
 
+# coverage report generated for the CI
+/coverage.lcov
+
 # These are backup files generated by rustfmt
 **/*.rs.bk