Skip to content

Re-enable GCC 9.x Debian CI - #697

Merged
Cropi merged 1 commit into
USBGuard:mainfrom
hartwork:restore-debian-gcc-9-ci
Sep 7, 2026
Merged

Re-enable GCC 9.x Debian CI#697
Cropi merged 1 commit into
USBGuard:mainfrom
hartwork:restore-debian-gcc-9-ci

Conversation

@hartwork

Copy link
Copy Markdown
Contributor

@Cropi what do you think?

@hartwork

Copy link
Copy Markdown
Contributor Author

@Cropi any thoughts?

@Cropi

Cropi commented Aug 31, 2026

Copy link
Copy Markdown
Member

@hartwork aren't the version check lines missing a closing quote? [[ "$(gcc -dumpversion) == 9.5.* ]] should be [[ "$(gcc -dumpversion)" == 9.5.* ]] ? The CI passed though. Also, on GCC 9+ gcc -dumpversion might return only the major version (9), which won't match the 9.5.* glob. Should gcc -dumpfullversion be used instead?

@hartwork
hartwork force-pushed the restore-debian-gcc-9-ci branch from 4a163a3 to 1081430 Compare September 6, 2026 22:08
@hartwork

hartwork commented Sep 6, 2026

Copy link
Copy Markdown
Contributor Author

@Cropi thanks for looking into it!

@hartwork aren't the version check lines missing a closing quote? [[ "$(gcc -dumpversion) == 9.5.* ]] should be [[ "$(gcc -dumpversion)" == 9.5.* ]] ? The CI passed though.

That's an interesting find — thanks! Fixed in a follow-up commit now.

Also, on GCC 9+ gcc -dumpversion might return only the major version (9), which won't match the 9.5.* glob. Should gcc -dumpfullversion be used instead?

I checked, it's returning 9.5.0 with this precise Docker image (gcc:9.5-bullseye). I believe we're good with plain -dumpversion.

@hartwork
hartwork force-pushed the restore-debian-gcc-9-ci branch 2 times, most recently from 958e648 to bbbfadc Compare September 6, 2026 22:20
@hartwork
hartwork force-pushed the restore-debian-gcc-9-ci branch from bbbfadc to 488a527 Compare September 6, 2026 22:43
@Cropi
Cropi merged commit ccf1822 into USBGuard:main Sep 7, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants