fix(ui5-date-picker): Fix background vs foreground width mismatch. - #13844
fix(ui5-date-picker): Fix background vs foreground width mismatch.#13844sap-lh wants to merge 1 commit into
Conversation
|
|
|
Hello @UI5/ui5-team-ctr-bal, Please review this PR. |
|
Hi @sap-lh, Could you please link the issue if exists? Regards, |
|
Hi everyone, We will check what the expected behaviour is, but in the meantime we noticed theres a related issue. Best, |
|
Hi @nnaydenow, it seems to be the same issue that @didip1000 mentioned, #13223 . Best regards, |
Added back a `width:100%` property that was removed in 89ccfb8. This property keeps the datepicker body width in sync with its background width. It might have been accidentally removed, since its counterpart in DateTimePicker.css is still used. Fixes: UI5#13223 Signed-off-by: Léo Hardt <leo.hardt@sap.com>
|
I see that CI was triggered for this PR. It doesn't look like the errors are related to it, though, since other PRs are failing on the same steps. |
Hi colleagues,
While updating our UI5 version, I noticed that some elements got 'glitched' out, and it's more apparent on dark mode.
I can verify that adding back the
width:100%property that was removed in 89ccfb8 resolves the issue. Notice that this property is still present in the DateTimePicker. It seems that its removal was not related entirely to the rest of the commit.Before


After
HTML description
ui5-date-pickerhas a full-wifth andbackground-color: var(--sapField_Background);property.ui5-datetime-input) does not have awidth:100%property anymore, so that this background is larger than the child element it is trying to cover.Regarding DTO, I work at SAP, but I will end the commit message with a sign-off regardless.
Thank you for your amazing work.
Thank you for your contribution! 👏
PR checklist
Check the Development Hints
Follow the Commit message Guidelines
For example:
fix(ui5-*): correct/fix sthorfeat(ui5-*): add/introduce sth. If you don't want the change to be part of the release changelog - usechore,refactorordocs.Add proper description about the background of the change and the change itself
Link to an existing issue (if available)
Use
Fixes: {#PR_NUMBER}to close the issue automatically when the PR is mergedor
Related to: {#PR_NUMBER}to just create a link between the PR and the issue.