-
Notifications
You must be signed in to change notification settings - Fork 84
refactor(builder): Create sap-ui-version.json by default
#1453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
maxreichmann
wants to merge
15
commits into
main
Choose a base branch
from
run-generateVersionInfo-by-default
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 14 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
e388d1f
refactor(builder): Remove default exclusion of "generateVersionInfo"
maxreichmann f42cc02
test(project): Adjust ProjectBuilder tests
maxreichmann 7fbe410
test(project): Adjust BuildServer tests
maxreichmann 8102fc8
docs: Add section to migrate-v5
maxreichmann 7b038de
docs: Refactor migration text
maxreichmann 7b68767
docs: Replace dead "API ref" links with sidebar menu guide
maxreichmann 9112743
test(project): Add test with exclusion of `generateVersionInfo`
maxreichmann 6acf9e5
refactor(project): Exclude task `generateVersionInfo` from server builds
maxreichmann f1649a2
refactor: Move "Side tasks done" out to dedicated PR (#1473)
maxreichmann d9a4c59
docs: Add sentence for `ui5 serve`
maxreichmann e66f756
refactor: Move exclusion logic of `generateVersionInfo`
maxreichmann 08268f1
refactor: Apply suggestion
maxreichmann b527bf5
test: Fix `endsWith()` problem
maxreichmann 9a51d5c
test: Fix try/catch issue
maxreichmann d982c4f
refactor: Address @RandomByte review
maxreichmann File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||
|---|---|---|---|---|---|---|---|---|
|
|
@@ -320,6 +320,16 @@ Update your `ui5.yaml` configuration to reference an existing middleware instead | |||||||
| | `serveThemes` | CSS files pre-built by `buildThemes` task and served via `serveResources` | `serveResources` | | ||||||||
| | `testRunner` | TestRunner resources served via `serveResources` from the UI5 framework | `serveResources` | | ||||||||
|
|
||||||||
| ## `sap-ui-version.json` | ||||||||
|
|
||||||||
| When running `ui5 build`, the standard task [`generateVersionInfo`](../api/module-@ui5_builder_tasks_generateVersionInfo) (producing a `sap-ui-version.json` file under `resources/`) is now **executed by default**. This applies to every build type (default, jsdoc, and self-contained) for projects of type `application`. For projects of other types (e.g. `library`), the behavior remains the same and [`generateVersionInfo`](../api/module-@ui5_builder_tasks_generateVersionInfo) is not executed. | ||||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||
|
|
||||||||
| ::: info Tip | ||||||||
| To see which standard tasks are executed for each project type, check out the [Standard Tasks](../pages/Builder#standard-tasks) table in the UI5 Builder page. | ||||||||
| ::: | ||||||||
|
|
||||||||
| When running `ui5 serve`, [`generateVersionInfo`](../api/module-@ui5_builder_tasks_generateVersionInfo) continues to **not be executed by default** because a corresponding middleware [`versionInfo`](../pages/Server.md#versioninfo) produces the same `sap-ui-version.json` output file. | ||||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||
|
|
||||||||
| ## Learn More | ||||||||
|
|
||||||||
| - [Project: Type `component`](../pages/Project#component) | ||||||||
|
|
||||||||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.