Introduce Worker Label type definition for extended and classic#1051
Open
kaisalmen wants to merge 1 commit into
Open
Introduce Worker Label type definition for extended and classic#1051kaisalmen wants to merge 1 commit into
kaisalmen wants to merge 1 commit into
Conversation
1c8e8dd to
0ec9824
Compare
Collaborator
Author
|
@CGNonofr are you ok with these changes? |
0ec9824 to
ef10b70
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upside: Clearer what are allowed worker names.
Downside: Needs to be maintained, but I think it's ok.
Fixes #1038