Skip to content

TT-17509: Disable vulnerability scanning in S1 PR workflow #1061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
probelabs wants to merge 1 commit into
base: master
Choose a base branch
from
Open

TT-17509: Disable vulnerability scanning in S1 PR workflow #1061

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/s1-cns-scans.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,8 @@
permissions:
contents: read
with:
iac_enabled: false

Check failure on line 15 in .github/workflows/s1-cns-scans.yml

View check run for this annotation

probelabs / Visor: security

security Issue 

Vulnerability scanning has been explicitly disabled in the S1 pull request workflow. This action removes a critical security control designed to detect vulnerabilities in dependencies and application code. Disabling this scan significantly increases the risk of introducing and merging code with known security flaws, which could be exploited in production.
Raw output 
Re-enable the vulnerability scan by removing the `vuln_enabled: false` line. If the scan is being disabled due to performance issues, false positives, or other operational problems, those specific issues should be addressed and remediated rather than disabling the security control entirely. If this scanner is being replaced by another tool, ensure the new tool is active and provides equivalent or better coverage.

Check warning on line 15 in .github/workflows/s1-cns-scans.yml

View check run for this annotation

probelabs / Visor: quality

security Issue 

Vulnerability scanning has been explicitly disabled by setting `vuln_enabled: false`. This action reduces the project's security posture by removing automated vulnerability checks from the pull request workflow. While this change appears intentional as per the PR title and associated ticket, it introduces a risk that new vulnerabilities may be merged without detection.
Raw output 
Ensure that this change has been reviewed and approved by the appropriate security stakeholders. If this is a temporary measure, consider adding a comment to the workflow file referencing the ticket or reason for disabling the scan, and outlining the conditions for its re-enablement.
vuln_enabled: false
tag: service:vulnscan
scope_type: ACCOUNT
secrets:
Expand Down
Loading