Lily/SoundExpanded -- Add 'stop all sounds in sprite' block - #2599
Lily/SoundExpanded -- Add 'stop all sounds in sprite' block#2599SharkPool-SP wants to merge 5 commits into
Conversation
github-actions
Bot
added
the
pr: change existing extension
|
!format |
|
The formatting bot didn't find any formatting issues. It currently only checks the extensions folder. The author or a maintainer can run terminal command 'npm run format' manually to format all files. |
|
This block offers no way to stop sounds being played by clones |
|
Is it not: 'stop all sounds in (myself)' |
|
That's better than nothing, at least |
That's an option in the block what do you mean: |
|
I know. The question was more about whether "stop all sounds in sprite1" should stop sounds from the clones too. |
|
Ah, I could add that. Also you should just start yolo merging my fix PRs... the other contributors seem inactive |
|
I might if no one else does |
|
I've also thought about just lowering it to 1 required review for changes to existing extensions |
|
|
!format |
I'm still alive but we definitely need more review activity around here to keep things running smoothly |
Brackets-Coder
left a comment
Brackets-Coder
left a comment
There was a problem hiding this comment.
Looks okay, but I'm in a quiet environment at the moment and don't want to make a bunch of noise testing so I'm going to probably test this in a few hours
Brackets-Coder
left a comment
Brackets-Coder
left a comment
There was a problem hiding this comment.
Works great
- I tested all modified functionality and found no bugs or unintuitive behavior.
- I believe a well-formed project using an older version of this extension will not be broken by this new version.
- I have no additional concerns.
|
!format |
At this point it's just down to you and me, eh? 😅 |
Preeeeetty muchg |
4 participants
Resolves:
#1650