🐛 Fixed free tier looking like a selectable card when it's the only tier#28951
Open
Aubaid12 wants to merge 1 commit into
Open
🐛 Fixed free tier looking like a selectable card when it's the only tier#28951Aubaid12 wants to merge 1 commit into
Aubaid12 wants to merge 1 commit into
Conversation
fixes TryGhost#25517 On a site with no paid tiers, the signup modal rendered the free tier inside a bordered, hoverable card (no price, no Choose button) — making it look selectable when there's nothing to choose. This removes the card framing for the only-free case and drops the now-pointless selection click, so the free tier reads as plain info above the Sign up button. Title, description and benefits are kept.
Contributor
WalkthroughIn 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #25517
When a site has Stripe connected but no paid tiers, the signup modal shows the free tier inside a bordered, hoverable card (no price, no Choose button). That makes it look selectable when there's nothing to choose, which is the confusion reported in the issue.
This removes the card framing (border, padding, background) for the only-free case and drops the now-pointless selection click, so the free tier reads as plain info above the Sign up button. The title, description, and benefits stay.
This follows the "possibly better" option in the issue. I kept the "Free" title because signup-flow.test.js already asserts it renders for only-free signups, and the issue flagged title removal with a "?", so it didn't seem worth changing. Happy to drop it if you'd prefer.
Multi-tier and single-paid signups are unaffected; the change only triggers when free is the only tier. The full Portal test suite passes.
No new test added: this is a presentational/CSS change that jsdom can't meaningfully assert, and the existing signup-flow tests already cover only-free rendering (title, description, benefits).
I've read and followed the Contributor Guide