test: exclude dist from vitest runs in every package - #254
Merged
Conversation
The package vitest configs build their `exclude` list on `configDefaults.exclude`, which no longer contains `**/dist/**` in vitest 5, so a compiled spec left in `dist` runs as a test. `svelte-router` produces exactly that: `svelte-package` compiles `src/*.spec.ts` into `dist`, and `test:dist-types` runs `build:dist` without the `clear:dist-assets` step, after which `vitest run` executes the stale `dist/*.spec.js` and fails. Every config now excludes `./dist` next to `./package`.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #254 +/- ##
=======================================
Coverage 83.33% 83.33%
=======================================
Files 98 98
Lines 2557 2557
Branches 552 552
=======================================
Hits 2131 2131
Misses 314 314
Partials 112 112 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Every package config builds its vitest
excludeas[...configDefaults.exclude, './package']. In the installed vitest 5,configDefaults.excludeis only**/node_modules/**and**/.git/**, sodistis no longer excluded.svelte-routeris where it bites:svelte-packagecompiles everything undersrc, specs included, intodist. Thebuildscript cleans them withclear:dist-assets, buttest:dist-typesrunsbuild:distalone, so afterpnpm test:typesa staledist/core.spec.jsstays behind and the nextvitest runexecutes it against outdated code.Reproduced with a throwing
dist/stale.spec.jsinpackages/svelte-router:vitest runpicked it up and failed; with./distexcluded the same file is skipped.What
exclude: [...configDefaults.exclude, './package', './dist']in all 19packages/*/vite.config.js, in the style of the existing./packageentry.svelte-routerkeeps its extra./.svelte-kit.Checks
oxlinton the configs passes.vitest runspot-checked inkida,react,svelteandsvelte-routerwith unchanged counts.