Repository navigation
Conversation
hxu129
marked this pull request as ready for review
October 20, 2026 21:37
Preserve the binder cache while probing the optional launch ABI before JIT construction. Keep the original optional-ABI regression tests unchanged.
liuanji
added a commit
that referenced
this pull request
Nov 4, 2026
Probe the optional launch ABI before constructing the JIT function (#65 on current main)
Member
|
Resolved by #74, now on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With fast launch enabled on Triton 3.0.0,
FastJITFunction3xconstructs a JIT function before importing the optionaltriton.knobsAPI. That import fails on this release, andtriton_jitconstructs the stock fallback, parsing the same kernel source twice. Probe the optional launch ABI first so the fallback constructs only one JIT function.This update merges current upstream main while preserving the original PR history. The constructor conflict is resolved by retaining main's new
self.binderscache and moving only the optionaldriver/knobsimports beforetriton.jit(fn). The newer argument binding and launch logic are retained; kernel arithmetic is unchanged. The original seven regression cases are preserved byte for byte.Validation on Python 3.10.14, PyTorch 2.4.0+cu121, Triton 3.0.0 and an RTX 4090:
triton.jitwas called twice. The baseline installation remained unchanged.For source-checkout reproduction, the focused command is:
The Triton 3.5.0 available-ABI construction branch is mocked; it is not a compatibility qualification for that release or other newer Triton versions. No application-level speedup is claimed.
AI assistance was used for implementation and test development.