Repository navigation
Lowrank sum params - #50
Merged
Merged
Conversation
…parameter handling - Removed redundant kernels and consolidated logic in the low-rank forward computation. - Introduced a new `tie_external` option in `LowRankSumParams` to allow sharing of external factors across tied nodes, optimizing memory usage and performance. - Updated the forward and backward methods to accommodate the new parameter tying mechanism. - Added tests to validate the behavior of tied external parameters and ensure gradient accumulation is correctly implemented. - Improved documentation and comments for clarity on kernel behavior and parameter interactions.
…dd corresponding test
…lots for improved clarity and consistency
…rom lowrank_forward.cu
… fitting config logic
…t and streamline tensor storage operations
…fsets and layout adjustments
…nd optimize tensor copying
… optimize shared memory usage - Removed the sigma parameter from the blockscale_forward kernel and related functions to streamline the interface. - Simplified the gate_pass and accum_z functions by eliminating unnecessary parameters and unrolled loops. - Optimized shared memory allocation and access patterns for improved performance. - Adjusted kernel launch configurations to reflect the changes in parameters and memory layout. - Enhanced the normalizer's operand computation to reduce redundant memory accesses.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.