(GH-162) Fix azure arc port number#163
Merged
Merged
Conversation
|
Thanks for the quick fix. I reviewed the diff and it correctly addresses the issue I hit — the Arc endpoint URL was defaulting to port 80 because the port was missing, causing "connection refused on 127.0.0.1:80". Adding :40342 (the fixed HIMDS default) resolves it, and I confirmed both call sites (the challenge request and the token request) are updated, with the native IMDS and service-principal paths left untouched. I haven't been able to run it fully end-to-end in my environment yet due to change-control constraints on our AWS compilers, but the code change matches exactly what I diagnosed. Code review LGTM, and I'll follow up with runtime validation once I can schedule the test. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Azure arc listens on port 40342 by default and cannot be changed. This fixes azure arc support which was broken.
Closes #162