refactor(engineio): move shareable constructs with future client to core#555
Draft
Totodore wants to merge 21 commits into
Draft
refactor(engineio): move shareable constructs with future client to core#555Totodore wants to merge 21 commits into
Totodore wants to merge 21 commits into
Conversation
Totodore
added
A-engineioxide
Totodore
changed the title
Stream + Sink based client implementation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Totodore
force-pushed
the
engineioxide-client
branch
from
096e8ed to
d111347
Compare
Totodore
force-pushed
the
engineioxide-client
branch
from
4bff1f2 to
3de1ec1
Compare
Totodore
force-pushed
the
engineioxide-client
branch
from
3de1ec1 to
47ad1b6
Compare
Totodore
force-pushed
the
engineioxide-client
branch
from
7a8712d to
a93e14d
Compare
Totodore
force-pushed
the
engineioxide-client
branch
from
a93e14d to
f41d1c3
Compare
Totodore
changed the title
Stream + Sink based client implementation
Totodore
commented
Jun 29, 2026
| ) -> Result<PacketBuf, Error> { | ||
| let packet = rx.recv().await.ok_or(Error::Aborted)?; | ||
| async fn recv_packet(mut rx: Pin<&mut Peekable<impl Stream<Item = PacketBuf>>>) -> PacketBuf { | ||
| let packet = rx.next().await.unwrap_or(smallvec![]); |
Owner
Author
There was a problem hiding this comment.
TODO: check implication from raising err to returning default.
Totodore
commented
Jun 29, 2026
Owner
Author
There was a problem hiding this comment.
TODO: check for yield_packets usage in the decoder
Totodore
added
C-Refactoring
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First step to build an engineio client with the same core. The future engineio client will need the following constructs:
TODO: check we dont loose packets with the current
Peekableimpl.