Fix frontend runtime errors after Calcit upgrade - #73
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the project to run cleanly after a Calcit upgrade by pinning compatible runtime/dependencies, hardening frontend runtime behavior against invalid state/API responses, and extending CI to validate/build and publish a frontend artifact for smoke testing.
Changes:
- Pin
@calcit/procsto0.13.36and bump Calcit/Respo-related deps to compatible versions (including a pinnedRespo/alerts.calcitcommit). - Make frontend runtime more defensive: normalize nested component state before map access; recover from invalid preview API responses; ensure some browser event callbacks return
nil. - Enhance CI with a top-level Calcit
--check-onlystep and uploaddist/as a short-lived artifact.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| yarn.lock | Locks @calcit/procs to 0.13.36 for reproducible installs. |
| package.json | Pins @calcit/procs to 0.13.36 to match the upgraded runtime. |
| deps.cirru | Updates Calcit/Respo dependency versions and pins Respo/alerts.calcit to a specific commit. |
| calcit.cirru | Adds defensive runtime checks for preview parsing/state shape and adjusts event handlers/config reads. |
| .github/workflows/upload.yaml | Adds Calcit check-only and uploads the built frontend (dist) as an artifact. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
Calcit 0.13.37 follow-up pushed in 77eb8b9. This now depends on Respo/respo.calcit#114 through prerelease branch 0.16.84-calcit-0.13.37.0 so caps selects the fixed dependency before formal release. Local verification passed: caps --ci, client/server check-only, yarn install --immutable, yarn compile-page, Node 24 Vite production build, and fresh production browser load with zero console errors. Not merging; waiting for both PR Actions. |
|
Follow-up: copyboard now depends on normal Respo 0.16.84, tracked by Respo/respo.calcit#115. Revalidated locally with caps --ci and yarn compile-page. |
Summary
Local checks
caps --ciyarn install --immutablecalcit calcit.cirru edit formatThis PR is intentionally not merged; Actions and the CI-built browser artifact will be verified first.