Skip to content

Fix frontend runtime errors after Calcit upgrade - #73

Merged
tiye merged 13 commits into
mainfrom
codex/fix-runtime-get-20260823
Aug 23, 2026
Merged

Fix frontend runtime errors after Calcit upgrade#73
tiye merged 13 commits into
mainfrom
codex/fix-runtime-get-20260823

Conversation

@tiye

@tiye tiye commented Aug 23, 2026

Copy link
Copy Markdown
Member

Summary

  • align Calcit runtime and compatible Respo dependencies, pinning the upgraded alerts source commit
  • normalize component state before map access and recover from invalid preview API responses
  • migrate unsafe config field reads and make browser event callbacks return unit
  • add client entry checking and a downloadable frontend artifact to CI

Local checks

  • caps --ci
  • yarn install --immutable
  • calcit calcit.cirru edit format
  • server check-only
  • client check-only with Calcit 0.13.36 before the local tool updated
  • production Vite build exercised with the newer local compiler; final browser smoke test will use the CI artifact built with the declared Calcit 0.13.36

This PR is intentionally not merged; Actions and the CI-built browser artifact will be verified first.

Copilot AI lite review requested due to automatic review settings August 23, 2026 14:47

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the project to run cleanly after a Calcit upgrade by pinning compatible runtime/dependencies, hardening frontend runtime behavior against invalid state/API responses, and extending CI to validate/build and publish a frontend artifact for smoke testing.

Changes:

  • Pin @calcit/procs to 0.13.36 and bump Calcit/Respo-related deps to compatible versions (including a pinned Respo/alerts.calcit commit).
  • Make frontend runtime more defensive: normalize nested component state before map access; recover from invalid preview API responses; ensure some browser event callbacks return nil.
  • Enhance CI with a top-level Calcit --check-only step and upload dist/ as a short-lived artifact.

Reviewed changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
yarn.lock Locks @calcit/procs to 0.13.36 for reproducible installs.
package.json Pins @calcit/procs to 0.13.36 to match the upgraded runtime.
deps.cirru Updates Calcit/Respo dependency versions and pins Respo/alerts.calcit to a specific commit.
calcit.cirru Adds defensive runtime checks for preview parsing/state shape and adjusts event handlers/config reads.
.github/workflows/upload.yaml Adds Calcit check-only and uploads the built frontend (dist) as an artifact.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread calcit.cirru
@tiye

tiye commented Aug 23, 2026

Copy link
Copy Markdown
Member Author

Calcit 0.13.37 follow-up pushed in 77eb8b9. This now depends on Respo/respo.calcit#114 through prerelease branch 0.16.84-calcit-0.13.37.0 so caps selects the fixed dependency before formal release. Local verification passed: caps --ci, client/server check-only, yarn install --immutable, yarn compile-page, Node 24 Vite production build, and fresh production browser load with zero console errors. Not merging; waiting for both PR Actions.

@tiye

tiye commented Aug 23, 2026

Copy link
Copy Markdown
Member Author

Follow-up: copyboard now depends on normal Respo 0.16.84, tracked by Respo/respo.calcit#115. Revalidated locally with caps --ci and yarn compile-page.

@tiye
tiye merged commit c3c52da into main Aug 23, 2026
1 check passed
@tiye
tiye deleted the codex/fix-runtime-get-20260823 branch August 23, 2026 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants