[http-proxy-agent] Set default SNI for HTTPS proxy servers - #440
Open
0xZoomEye wants to merge 2 commits into
Open
[http-proxy-agent] Set default SNI for HTTPS proxy servers#4400xZoomEye wants to merge 2 commits into
0xZoomEye wants to merge 2 commits into
Conversation
🦋 Changeset detectedLatest commit: 533132f The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When HttpProxyAgent connects to an HTTPS proxy, it calls
tls.connect() with host and port but without servername.
Node.js does not enable SNI automatically for tls.connect(),
so virtual-hosted HTTPS proxies may return their default
certificate and fail certificate validation.
This change defaults servername to the proxy hostname when
the hostname is not an IP address, matching the existing
behavior in https-proxy-agent.