fix(agent-base): dispatch queued requests after connection failures - #439
Open
rajanpanth wants to merge 1 commit into
Open
fix(agent-base): dispatch queued requests after connection failures#439rajanpanth wants to merge 1 commit into
rajanpanth wants to merge 1 commit into
Conversation
🦋 Changeset detectedLatest commit: 8fd1eb2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Author
|
Friendly follow-up on this PR 👋 When you have a moment, could you please take a look? I’m happy to rebase, update tests, or make any requested changes. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
maxSockets: 2agent-baseFixes #427.
Problem
When an asynchronous Agent connection attempt rejects, Agent Base removes its placeholder socket but does not enter Node's normal socket-close queue-draining lifecycle.
With four same-origin requests and
maxSockets: 2, the first two connection attempts reject while the other two requests remain queued indefinitely.Change
After removing the failed placeholder, dispatch the next same-origin queued request when capacity is available. Requests are shifted before dispatch, so repeated failures drain the queue without redispatching the same request.
Validation
git show --check— passedNode 20 was not tested locally because it is not installed.
The aggregate Turbo command resolves global pnpm 11.14 instead of the repository-pinned pnpm 10.30.3. Repository-wide formatting also reports 123 existing Windows CRLF differences. All changed files pass their targeted validation.
A separate PAC test fixture is locally protected with
skip-worktreebecause Windows Defender blocks access. That fixture is unrelated to this change and is absent from the commit and pull-request diff.Compatibility
No public API, Node support, dependency, lockfile, or TypeScript declaration change is included.