Support multipliers per mode - #528
Conversation
band bit was set even the multiplier didn't actually count adapted test case also
for the moment mode is not considered, all mapped to CW
|
Code is mostly ready, the harder part is now the configuration as the legacy boolean configs define the multiplier application mode implicitly: SECTION_MULT and SECTION_MULT_ONCE, etc. |
|
Added the new BAND+MODE value to UNIQUE_CALL_MULTI and GENERIC_MULT. The remaining configs are these booleans
The approach will be add for example WYSIWYG_MULTI with the same values are for GENERIC_MULT, but also keep the legacy configs. So for example WYSIWYG_ONCE will be equivalent to WYSIWYG_MULTI=ALL. |
and also handle the legacy boolean configs WYSIWYG_MULTIBAND / WYSIWYG_ONCE
the old boolean behavor is also preserved
|
Multiplier configs without "only" were kept as-is for the moment. Updated pacc_dx and included a test for it. |
|
Migrated IOTA to BAND+MODE mult setting. |
|
Came across SERIAL_OR_SECTION: despite the promising description in the man page it does merely control the showing of the "section?" pop-up. I think it is safe to assume that the user is aware of the rules, so an extra question is just causes confusion. |
|
I'd do man page update in a separate PR as we have #525 that also touches the man page. |
dl1jbe
left a comment
There was a problem hiding this comment.
It is quite a bit of work to study so comments are preliminary.
- Base concept looks good. Mult handling seems also well implemented.
- A change of controlling keywords seems really needed. But i like that we harmonize the usage, e.g. 'GENERIC_MULT = NONE|ALL|....'.
- Do we have a way to announce the old keywords as 'deprecated' to motivate for migration?
- Just as a comment: I always have mental problems to connect 'ALL' to 'mults counts only once per contest'. The old 'ONCE' triggers more cells in my brain.
|
ALL makes me also think a bit more, than optimal. ONCE is definitely more intuitive. Adding deprecation shouldn't be an issue, I have to just check how this affects the tests. |
|
Very well. Looks like it is ready to go in. +1 |
|
Changed ALLs into ONCE in rules. Will address deprecation warning after the merge-in to handle it with a common function. |
A number of contests use multipliers by band and mode. Currently TLF supports only mults by band. The goal is to add support for mults by band and mode.
The basic idea is to extend the single
bandfield inmults_tinto a arrayband[mode]and inremember_multi()consider also mode, if needed.