Allow seamless editing of call input field - #516
Conversation
|
Adding two helper functions
|
|
Now incorporating the editing functions into the switch statement of Ctrl-A from editing clashes with the one from call input. One has to use Home key to navigate to the start of the input field. The different color scheme used when editing is now gone. Should be no issue. Apart from the generic working at least these special cases have to be checked
|
|
USEPARTIALS can also lead to modification of the call field. In this case we move the cursor to end of the call, as if it would my manually entered. In order to allow editing when using USEPARTIALS we have to block further autofilling by setting |
|
Memory operations (pop/swap) will try to keep cursor position. |
|
Moving cursor to the end of the call on Fldigi grab. |
|
Not directly related to editing, but fixed USEPARTIAL triggering on a numbers-only entry. |
dl1jbe
left a comment
There was a problem hiding this comment.
Looks good.
The critical point seems the lot of 'pos = ...' manipulations. Let us hope all relevant cases are handled.
Do you want to merge it in now and do the edit of exchange in a second PR or do plan to add it to these PR also?
|
Keeping track of Exchange will the addressed in a separate PR, but based on the solution worked out here. |
* add callsign input field editing using insert_car/delete_char helper functions * USEPARTIAL: do not trigger autofill on a number * USEPARTIALS: move cursor to the end of the call + disable further fill on editing; * release blocking of partials if call is empty * try to keep cursor position for trx memory operations * move cursor after the call on fldigi grab * fix underlining length when autosend is used * update man page * remove calledit.c * remove legacy unused para_word
Rethinking #495, focusing here on call input field only. Later on
getexchnagecan be changed the same way.The goal is to achieve seamless editing of the callsign input field using the usual editing keys, while keeping the other special keys operational. Taking the approach of integrating editing into
callinput()as mentioned as an option in #495.First dropping the unused the 'int insert_char(int)' function. At the end the whole
calledit.cfile will be dropped.