Repository navigation
Port bazel-diff contributor logic into README generator - #41
Merged
tinder-maxwellelliott merged 1 commit intoOct 24, 2026
Merged
Conversation
Build the Contributors section the way Tinder/bazel-diff does: authors come from `git log` (rolled up by name, sorted by commit count), emails resolve to GitHub logins via the commits API for avatars and profile links, with a noreply-address fallback, and bots are filtered out. Render a 6-column table with avatar and display name instead of the bare avatar row. - Add unit tests for the contributor logic and run them in CI - Add `make generate_readme` and `make readme_tool_test` - Regenerate README.md with the new table Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Borrows the contributors section logic from Tinder/bazel-diff so we can showcase everyone who has contributed to sign-here.
git log, not the GitHub contributors API, so every committer appears. Commits are rolled up by author name (keeping the email with the most commits) and sorted by commit count.<id>+<login>@users.noreply.github.comfallback.GITHUB_TOKENis used when set to avoid rate limits.type == "Bot"or a[bot]suffix).Small departures from bazel-diff: author names are HTML-escaped, and
--offlinenow still produces a names-only table from git history (with a warning per unresolved author) instead of a placeholder.Changes
tools/readme/generate_readme.py: contributor logic ported; old_fetch_contributorsremovedtools/readme/generate_readme_test.py: 14 unit tests (bot detection, noreply parsing, roll-up, escaping, column wrapping, fallbacks)Makefile:generate_readmeandreadme_tool_testtargets.github/workflows/ci.yaml: run the new self-tests alongside the coverage tool self-testsREADME.md: regenerated Contributors section; all 7 contributors resolve with avatarsTesting
make readme_tool_testpasses locally (14 tests).bazel run //:generate_readmewas not run locally (no Xcode on this machine), so the rest of the README is unchanged from the current generated output.🤖 Generated with Claude Code