Conversation
Use rules_rs for Rust toolchains, Cargo.lock resolution, and Rust targets. Use llvm for C/C++ toolchains and the built-in rules_rs musl platforms for static Linux amd64 and arm64 releases. Remove custom musl repositories, libc constraints, and cargo-bazel-lock.json. Require Bazel 8.5 and pin LLVM 22.1.8 for Rust 1.90 coverage compatibility. Preserve the Rust 1.85 check and Cargo's vendored-protoc default. Configure Windows MSVC/SDK acceptance through repository variables. Shorten build and workflow comments, simplify static ELF checks, and remove the dedicated Alpine stress workflows. Validation: 13 native test targets, Rust coverage thresholds, Rust 1.85 build, cargo check --locked --tests, Bazel 8.5 archive consumer build, Bazel 9.2 analysis, and both Linux musl release cross-builds with static ELF checks.
Distinguish None from the empty root package in the five generated rules_rs helpers. Restore Cargo dependency discovery for src and tests, retaining the build script dependency needed with Bazel-supplied protoc. Document Bazel 8 or higher and the temporary root-module patch override required by consumers. Apply the same override in the consumer workflow.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace direct
rules_rustandtoolchains_muslconfiguration withrules_rsandllvm. Resolve crates fromCargo.lockand use the built-in musl platforms for static Linux amd64 and arm64 releases. Remove the custom libc constraints, musl toolchain repositories, andcargo-bazel-lock.json; retain the Alpine stress workflows.Keep
all_crate_depsinsrc/BUILDandtests/BUILDwith a five-linerules_rspatch distinguishingpackage_name = Nonefrom"". Document and test the same temporary override for consumers, because Bazel ignores dependency modules' overrides. A BCR release still requires arules_rsrelease containing the fix.Simplify
.bazelrc, release checks, and workflow comments. Test Bazel 8.x and 9.x in the BCR matrices and document Bazel 8 or higher. LLVM 22.1.8 preserves Rust 1.90 coverage support. Windows MSVC/SDK license acceptance comes from repository variables; Windows builds remain unvalidated locally.Validation: 13 native test targets, Rust coverage thresholds, Rust 1.85 build,
cargo check --locked --tests, packed-archive consumer build with the temporary override, Bazel 9.2 analysis, and both Linux musl release cross-builds with static ELF checks.-zbarskybot