Repository navigation
Let a game publish single sound banks and sequences - #34
Open
SirFancyBacon wants to merge 4 commits into
Open
SirFancyBacon wants to merge 4 commits into
SirFancyBacon wants to merge 4 commits into
Conversation
cargo fmt --check failed on master in eight files, which stopped the Rust CI job at its first step on every pull request. Formatting only; no code changes.
clippy -D warnings failed once formatting passed: SourceBytes had len without is_empty, a nested if in the DC1 fixed-texture path could be one let chain, and job_set_run takes a Box. The Box stays: the host hands the set over through the bridge as the Box it owns, so the lint is allowed there with that reason.
CMake 4's Ninja generator lists its other outputs on the regeneration edge (build build.ninja <more>: RERUN_CMAKE), so the two tests that looked for the line build build.ninja: RERUN_CMAKE found none on the CI runner's newer CMake. They now accept either form.
A game whose sound packs differ from Dark Cloud 2's walks them itself: Dark Cloud's packs hold up to eight banks each, one per driver slot, and their own load lists and tables. audio_publish_bank and audio_publish_sequence convert one HD/BD bank into bank JSON and WAV samples, or one SQ sequence into sequence JSON, at a path the game chooses, through the converter's existing bank and sequence code, so the published formats are unchanged.
SirFancyBacon
force-pushed
the
chronicle-audio-publish
branch
from
October 25, 2026 21:40
389100a to
ac118f7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires #35, which fixes master's CI; this branch is built on it, so its CI passes once #35 is in. This PR's own change is the last commit.
Lets a game publish one Sony HD/BD bank or one SQ sequence in the existing sound formats, at a path it chooses.
audio_publish_bank(key, hd, bd, data_out)andaudio_publish_sequence(key, sq, data_out), over the converter's existing bank and sequence code (publish_bank/publish_sequenceinaudio.rs). The published formats are unchanged, and Dark Cloud 2's conversion is untouched.a_game_publishes_single_banks_and_sequences_at_the_converters_paths.cargo fmt --checkandcargo clippy -D warningsalready fail on master in files this doesn't touch (host_jobs.rs's boxed local,SourceByteswithlenbut nois_empty, a collapsibleif, and unformatted lines inarchive.rs,jobs.rs,textures.rsand others). This change adds no new warnings.Used by TheMoonPeople/Chronicle#226 (Dark Cloud's sound in these formats).