Repository navigation
Port: fix dungeon crashes from PC memory and map staging limits - #97
Merged
Adubbz merged 1 commit intoOct 18, 2026
Merged
Conversation
Raise character model stack budgets and main_buffer headroom, isolate dungeon monster/FX arenas from MainBuffer, and enlarge BuffReadData with staging guards and tests so large floor maps (e.g. d04f01s) cannot overwrite later globals.
millerscout
added a commit
to millerscout/ChronicleTwo
that referenced
this pull request
Oct 17, 2026
millerscout
added a commit
to millerscout/ChronicleTwo
that referenced
this pull request
Oct 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes PC dungeon crashes from:
ArenaOverflowon human model stack 0 at the retail 68500 qw cap when entering dungeons with datapack JSON.LoadMapDatachains floor assets intoBuffReadDatawith no retail bounds check; large PC floors (e.g.d04f01s) exceeded the 200k qw buffer and overwrote laterMainBufferobjects (TreasureBoxMan,CMonsterMan, etc.).Approach:
port_memory_budget.hppdeltas, largermain_buffer/BuffReadData, dedicated arenas for dungeon monster/FX singletons,PortAssertDungeonReadCursor, stage rest checks, docs indocs/PC.md, and tests (CharaMemBudget,DungeonMapStaging,DungeonStageBudget, headless dungeon smoke whenport/runis present).Rebased on current
master(includes #72, #78, quick loadout, etc.).Test plan
ctest -R 'CharaMemBudget|DungeonMapStaging|DungeonStageBudget'withport/rundatadarkchronicle_testsd04f01svia_LOAD_DUNGEON_MAP_FILE