Repository navigation
Port: rebindable quick loadout key and controller bindings (#114) - #149
Merged
Merged
Conversation
The quick loadout panel opens on its own binding, quick_loadout: Down on the keyboard and the D-pad's Down on a controller by default, as before. Controllers get a binding set apart from the keyboard's, input.gamepad_bindings in config.json, edited on a new Gamepad page of PC SETTINGS (the Bindings page is now Keyboard). A capture takes any button or trigger, cancelled by Escape, a right click or five seconds; a button another pad button's action has swaps over, and Restore binding puts the default back the same way. Button names follow the glyph style, and the game's symbols and the page's prompts follow the controller bindings. Kazarov: controller binding set and quick_loadout host action. Closes #114
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #114
Needs Kazarov PR #32 (controller binding set, quick_loadout host action) merged first.
The quick loadout panel now opens on its own binding, quick_loadout: Down on the keyboard and D-pad Down on a controller by default, so nothing changes until it is rebound.
Controllers get a binding set separate from the keyboard's, input.gamepad_bindings in config.json, edited on a new Gamepad page in PC SETTINGS (the Bindings page is now Keyboard). Pad buttons and the port's own actions (quick loadout, FPS toggle, debug menu, gyro hold) take SDL gamepad button names or lefttrigger/righttrigger. Actions left out keep their defaults: the pad's own layout, and the paddle defaults for the host actions, which move from the keyboard set (keyboard Gamepad: bindings still work).
Capture takes any button or trigger. Escape, a right click, Cancel capture or five seconds cancels it.
A button already used by another pad button's action swaps with it, and Restore binding puts the default back the same way.
Button names follow the glyph style, and with new glyphs the game's button symbols and the page's prompts follow the controller bindings.
Tests: new PcOptions coverage for swapping, restoring and glyph mapping; PlatformConfig round trip.