Repository navigation
Port: Keyboard fixes for walk, debug menu and typing in keyboard pages (Granny Rosa, C7 boss fight quiz...) (#49, #63, #121) - #144
Merged
Conversation
Holding Walk (Left Shift) makes keyboard movement walk; PC SETTINGS > Controls > Keyboard movement swaps walking and running (#49). The Debug menu binding (F1) opens the developer menu like Start+Select when debug controls are enabled (#63). The name entry screen accepts typed letters, digits and grid symbols, with Backspace, Delete and Return, outside Japanese (#121). Bumps Kazarov for the walk action and text entry.
The mode_debug_menu binding (F2) turns DebugFlag on and presses R3 once, opening the town, dungeon or menu debug menu from the keyboard (#63). The developer menu (F1 or Start+Select) and F2 do nothing while PC SETTINGS waits for a key to bind or that key is still held.
drkm9743
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #49, fixes #63, fixes #121.
Needs the Kazarov PR above (submodule bumped to its commit).
Before: keyboard movement always ran, so the chapter 2 boss part that needs walking was impossible on keyboard; the "Debug menu" binding in PC SETTINGS did nothing and the R3 debug menus had no keyboard key; the name entry screen ignored the physical keyboard.
After: holding Left Shift walks, and PC SETTINGS > Controls > Keyboard movement can make keys walk with Shift to run. With debug mode on, F1 (Bindings > Developer menu) opens the developer menu like Start+Select, and F2 (Bindings > Debug menu (R3)) turns DebugFlag on and presses R3 once, opening the town, dungeon or menu debug menu. None of these shortcuts act while PC SETTINGS is waiting for a key to bind. On the name entry screen (non-Japanese), typing letters, digits and the grid's symbols writes them at the caret, Backspace/Delete act as the Back/Delete buttons, Return accepts the name, arrows still move on the grid and Escape cancels.
How:
input.keyboard_walkconfig + row;GameDeveloperMenuRequestedalso takes thedebug_menuhost press;CGamePad::UpDatehandlesmode_debug_menu;options::Capturing()blocks the shortcuts during a rebind;port/src/nameregi.cppoverridesNameRegistKeyto apply typed characters the wayKeyStepapplies grid presses, usingNameRegiMenuPtr/NameRegistMaxexposed throughport/include/stubs/nameregi.hpp. ps2/src is untouched. Docs updated in PC.md and DEBUG.md.