Repository navigation
Move the dungeon menu's Limited zone window to the top right - #251
Open
SirFancyBacon wants to merge 1 commit into
Open
SirFancyBacon wants to merge 1 commit into
SirFancyBacon wants to merge 1 commit into
Conversation
Retail puts it low on the left, where the rows the port adds to the ring (Options, Quit) now run, so it covered them. It goes to the top right of the screen instead, as far in as the help box, right-aligned by its own text so every message and language fits.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On a limited floor, the dungeon menu shows a "Limited zone" window. Retail puts it low on the left, which used to be empty. The port's added ring rows (Options, Quit) now fill that corner, so the window sat on top of Quit.
The window now goes to the top right of the 640x480 area: 20 px in from the right edge, the help box's margin, and 20 px down from the top. It's right-aligned using the width of its own text, so every limit message fits in any language. Only
port/src/battlemenu/main_ring.cppchanges, and only where the window is placed.Testing: