Repository navigation
Build the port without warnings - #241
Open
SirFancyBacon wants to merge 1 commit into
Open
SirFancyBacon wants to merge 1 commit into
SirFancyBacon wants to merge 1 commit into
Conversation
The PC build gave nine warnings, none of them a change in behaviour to make: - The debug weapon-stat cheat's messages printed a stray conversion, "%\n"; they print the percent sign now. - The debug item list's converter ruled out a range above the Scorpion (352) and below Super Steve (312), which holds no number, as retail's does; the empty check is gone. - The Atla events' origin and the event item board's pick past the last item were read unset, as retail reads them; they are zero, as the build's zero-initialisation already made them, and say so. - Six copies of an effect or a map part over another of its class copy the class's own vtable pointer; the copies say so to the compiler.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Build the port without warnings
The PC build gave nine compiler warnings. This clears them all without changing what the game does.
fixes #242
battlemenu.cpp: the debug weapon-stat cheat printed"now 20%\n", an invalid conversion.It prints the percent sign now (
%%).menu_dungeon.cpp:ConvDebugSelectToExcelListNorejected the numbers above the Scorpion(352) and below Super Steve (312). That range is empty, and retail's source has the same check, so
it never rejected anything. The dead check is gone.
dungeonmap.cppandmenu_save.cpp. Retail readsthem the same way. The build's zero-initialization already made them zero; they now start at zero
explicitly.
event_xandevent_yare the Atla events' origin.slotis the event item board's pick past its last item.dun/gameloop.cpp,editground.cpp: sixmemcpycalls copy an effect or a map part overanother object of the same class, so the vtable pointer they copy is the class's own. Both ends
are cast to
void *to tell the compiler this is deliberate.Testing
hardware renderer.