Repository navigation
Fix crash when giving Goro his father's amulet (Bone Pendant) - #238
Open
IvanPerrella wants to merge 1 commit into
Open
IvanPerrella wants to merge 1 commit into
IvanPerrella wants to merge 1 commit into
Conversation
gedit/s01/chara/e105.chr holds c06w01.img twice. dcdata keeps the first one's name and gives only the later one its position (#entry:21), but PackNameDuplicated marked both, so the first resolved to a baked document that does not exist and the game aborted while giving Goro the Bone Pendant. Only a later member of the same name now takes its position.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Giving Goro the Bone Pendant aborted the game with
missing texture document textures/gedit/s01/chara/e105-c06w01-entry-18_img-….json.gedit/s01/chara/e105.chrholdsc06w01.imgtwice (entries 18 and 21). dcdata keeps the first one's name and gives only the later one its position (#entry:21), butPackNameDuplicatedmarked both, so the first resolved to a document that was never baked.PackNameDuplicatednow flags only a later member with the same exact name, matching the extraction.DataRead.OnlyALaterMemberOfTheSameNameTakesItsPositionfails without the change.