[Tororoi]

Casting a fishing line crashes the macOS ARM build.

While the float is pinned (FishLineSetUki with a weight of 0 or more, as on every cast), FishLineStep copies uki into both point[18] and ukip[0] at the end of each relaxation pass. On the next pass, length between them is 0, so length * (1 - weight) / length is 0/0:

• On the EE that division gives a finite result, and the float doesn't move.
• On a PC it gives NaN. The NaN spreads through the float ring and the line into Toan's position, and the game crashes in CCollisionMDT::PickUpNearPoly (SIGBUS, from EdMoveChara).

port/src/fishing.cpp now overrides FishLineStep next to its FishLineDraw override. It is retail's function, except that a zero length becomes 1, which gives the same zero move the EE does. ps2/src is unchanged. Retail's two link tables are static in ps2/src/fishing.cpp, so the override keeps its own copies.

Testing

• New test: FishingLine.APinnedFloatStaysFinite fails without the change and passes with it.
• In game, on macOS ARM, PAL disc: Toan was walked to the Muska Lacka fishing sign with stick input, then the fishing menu, bait (Potato Cake) and cast used ordinary button presses.
  • Before this change, the cast crashes with the stack above.
  • After it, the line settles in the water and fish come to the hook.
• Linux x86_64: the bug was reported there too (Flatpak, casting with a Prickly in Matataki: the screen turns one colour, the bait runs out, and leaving the fishing menu crashes). I haven't run the fix there.

[SirFancyBacon]

Confirmed on Linux x86_64 as well. On the Flatpak build, casting with a Prickly in Matataki turned the screen a single color and the game said the bait had run out. Leaving the fishing menu then crashed.

That said your PR touches ps2 source files; can you make the adjustment in the port files instead?

[Tororoi]

Confirmed on Linux x86_64 as well. On the Flatpak build, casting with a Prickly in Matataki turned the screen a single color and the game said the bait had run out. Leaving the fishing menu then crashed.

That said your PR touches ps2 source files; can you make the adjustment in the port files instead?

Done.