Skip to content

Keep interior camera markers alive between SetCameraPos calls #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
IvanPerrella wants to merge 1 commit into from
Closed

Keep interior camera markers alive between SetCameraPos calls #216

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions port/src/edit_in.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1410,8 +1410,10 @@ PORT_OVERRIDE void SetCameraPos(CFrame *frame, CCamera *camera, CCharacter *char
if (camera_capacity == 0) {
return;
}
auto cameras = std::make_unique<INTERIOR_CAMERA[]>(static_cast<std::size_t>(camera_capacity));
sceVu0FMATRIX matrix;
/* active_camera keeps pointing at an entry between calls. The original's stack array sat at the
same address every frame, so that entry was the one rebuilt here; the storage must outlive the call. */
static INTERIOR_CAMERA cameras[8];
sceVu0FMATRIX matrix;
count = 0;

for (i = 0; i < func_num; i++, point++) {
Expand Down