Repository navigation
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7eb5587087
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (gfx::VisibleLogicalRect(gfx::kMainTarget).y >= 0.0f) { | ||
| return; | ||
| } |
There was a problem hiding this comment.
When a named fog frame has already been created, changing the title-screen Aspect option (or resizing) from a tall viewport to 4:3/wide takes this return and stops updating it. On switching back to tall, TitlePortFog accepts the still-registered handle before the new snapshot at port/src/title/titleloop.cpp:424, so it feeds seconds-old contents through the 112–114/128 feedback instead of using the continually updated frame_image; that stale background then persists as a visible jump/ghost for several frames. Track whether the target has a capture for the current layout, or seed it before reuse.
Useful? React with 👍 / 👎.
|
@codex review |
|
Codex Review: Didn't find any major issues. What shall we delve into next? Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Summary
Extend title-screen fog to the visible viewport above and below the original logical frame, and scale the smoke animation vertically so its off-screen return path stays hidden.
The existing title fog uses a partial-height feedback texture and bands bounded to the original screen. On taller-than-4:3 displays, this leaves sharp strips above and below the blurred background.
Dependency — do not merge yet
Ready for code review, but do not merge yet. Requires TheMoonPeople/Kazarov#18 to merge first, then Chronicle's Kazarov submodule must advance to the merged commit and the integration checks must pass. This PR currently does not change the submodule pointer.
Validation
Integration-tested with master 50eaff6 plus the existing Android support and the linked Kazarov fix:
No macOS runtime test was available. These are rendering checks, not a performance benchmark. The local PAL test extraction reports 35 altered/missing entries from earlier test setup; tested title/menu scenes loaded successfully.
The branch contains only the title changes on current master. No ps2 files, Android-specific UI code or game assets are changed. Rendering remains through shared Vulkan.
Review fix validation (6362221): Clang syntax check passed for title_port.cpp. A focused harness using the actual capture/selection functions passed initial capture, tall-to-wide-to-tall, tall resize, and recreated/missing-target cases. No new device rendering run was performed for this follow-up; CI is pending.