Add Android support for Chronicle by anxiousintrovert · Pull Request #188 · TheMoonPeople/Chronicle

anxiousintrovert · 2026-10-14T23:18:36Z

Summary

Add a native Android app with landscape rendering, first-run disc selection, Android graphics presets and touch overlay settings.
Keep Android saves and setup in the port layer. No ps2/ files change; use the shared Vulkan renderer from Add opt-in frame resolution scaling to the shared Vulkan renderer Kazarov#9.
Package SDL3 native libraries from the pinned AAR for both ARM64 and x86_64. Add an optimized profile build variant; leave Debug behavior unchanged.

Review updates

Implement the Java opacity callback and handle JNI lookup exceptions.
Release JNI local references during setup, consume picker results before retry, and wake the native waiter when Close is selected.
Pin Kazarov 611182d, including renderer/input review corrections, redundant Android guard cleanup, and the rotated-surface swapchain fix.
Shadow allocation improvements are separate: Reduce temporary allocations in shadow volume rendering #192. They are not included here.

Building

cd android
.\fetch-deps.ps1
.\gradlew.bat assembleDebug
# Optimized native code with debug symbols:
.\gradlew.bat assembleProfile

The submodule pins the Kazarov PR branch until its dependency merges. APKs contain no game data; players supply their own disc image.

Validation and scope

ARM64 and x86_64 builds succeeded during local validation. On an API 35 x86_64 emulator using host RTX 3080 Vulkan, a fixed Wise Owl Forest camera workload improved from about 14.5 ticks/s to 59.5, with a 60.0 repeat after the swapchain correction. These are aggregate counter measurements, not frame-time percentiles or Fold benchmarks. The measured build also included the independently proposed shadow allocation change; its isolated gain was small and inconclusive.

The ordinary APK survived emulator display-size changes, background/resume and short screen recordings. Physical Fold/Samsung recorder and desktop regression validation remain pending. The final redundant-preprocessor cleanup was checked structurally and formatted but not rebuilt. Repository formatting and whitespace checks passed. No APKs, game assets, saves or benchmark harnesses are committed.

Dependency compatibility — do not merge yet

Requires Kazarov #9 and a final compatible upstream submodule pin before merging. The current pin is 611182d on codex/chronicle-android-compatible: it merges Chronicle's upstream renderer pin 1a8f9ab into the reviewed Android revision 69c4247, retaining the audio APIs Chronicle uses while adding upstream's game-icon support. Kazarov #9's newer b08520d head still requires the corresponding Chronicle audio/asset migration; this PR does not claim to complete that migration.

Merge conflict resolution (2026-10-17)

Merged upstream master 50eaff6, preserved the Android build documentation alongside the new upstream README, and retained both the Android startup trace and upstream data-icon setup. The renderer compatibility merge resolves the submodule conflict without adopting the incompatible audio API changes.

Validation: Windows game and test executables built successfully; 85 selected icon, audio, and input tests passed (one benchmark disabled). Android ARM64 RelWithDebInfo native library built successfully. No new APK packaging or device runtime test was performed for this merge. CI must complete on the updated PR.

chatgpt-codex-connector · 2026-10-14T23:18:47Z

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-10-18T13:55:34.043388Z	`455dd7e`	Manual request

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9b62464385

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-10-14T23:26:27Z

+        return;
+    }
+    jclass    cls = env->GetObjectClass(activity);
+    jmethodID method = cls ? env->GetMethodID(cls, "setTouchControlsOpacity", "(F)V") : nullptr;


Implement the Java opacity callback before looking it up

On every Android launch, Run calls this function at port/src/main.cpp:453, but a repo-wide search finds no setTouchControlsOpacity(float) implementation in ChronicleActivity (only the visibility callback exists). GetMethodID therefore raises a pending NoSuchMethodError before renderer initialization, the new opacity option never applies, and subsequent JNI calls can abort the SDL thread; add the activity method and handle lookup exceptions.

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-10-14T23:26:27Z

+    jobject activity = static_cast<jobject>(SDL_GetAndroidActivity());
+    if (env == nullptr || activity == nullptr) {
+        return;
+    }
+    jclass    cls = env->GetObjectClass(activity);


Release JNI references after each status update

During first-run extraction, the progress callback calls AndroidShowStatus up to every 500 ms. SDL_GetAndroidActivity() returns a JNI local reference and GetObjectClass() creates another, but this helper never deletes either; because SDL_main is the long-lived JNI invocation, these references accumulate instead of being popped after each C++ helper return, so a slow extraction can overflow Android's local-reference table and abort setup. Delete both references on every path, and apply the same ownership rule in the hide/picker helpers.

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-10-14T23:26:27Z

+    }
+    std::unique_lock lock(android_picker_mutex);
+    android_picker_changed.wait(lock, [] { return android_picker_answered; });
+    return android_picker_path;


Consume the picker result before waiting for a retry

When the initial picker is canceled or the selected image fails extraction, this returns without clearing android_picker_answered (and for a non-null result it also leaves android_picker_path populated). The error branches then call WaitForAndroidRetry, whose predicate is already true, so cancellation immediately reopens the picker behind the error dialog and a failed multi-gigabyte image is automatically extracted a second time instead of waiting for the user. Consume and reset the result under the lock before returning.

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-10-14T23:26:28Z

+                .setTitle("Disc image could not be imported")
+                .setMessage(message)
+                .setPositiveButton("Choose another image", (dialog, which) -> requestDiscImage())
+                .setNegativeButton("Close", (dialog, which) -> finish())


Wake the native retry wait when Close is selected

After a canceled selection or copy/extraction failure, native startup can be blocked in WaitForAndroidRetry, but the negative button only finishes the Activity and never changes or notifies that condition. The SDL startup thread therefore remains blocked during Activity teardown, so choosing the offered Close action can hang instead of exiting; add an explicit native cancellation/exit signal that wakes the waiter and terminates the first-run loop.

Useful? React with 👍 / 👎.

anxiousintrovert · 2026-10-18T13:45:28Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 455dd7e6e8

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-10-18T13:55:31Z

+    file(COPY ${CMAKE_SOURCE_DIR}/tools/font/DarkCloudCompendium.ttf DESTINATION ${ANDROID_ASSETS}/lang)
+    file(COPY ${CMAKE_SOURCE_DIR}/tools/font/DarkCloudCompendiumThin.ttf DESTINATION ${ANDROID_ASSETS}/lang)


Rename Android fonts to the filenames the runtime loads

On a fresh Android install these copies preserve the basenames DarkCloudCompendium.ttf and DarkCloudCompendiumThin.ttf (which are also the names committed under assets/lang), but the runtime only searches for font.ttf in port/src/clsmes.cpp:58 and font_thin.ttf in port/src/caption_text.cpp:130. Since font_sharp defaults to true, the shipped fonts are never found and text silently falls back to the PS2 bitmaps; copy them with the same renamed filenames used by the desktop branch.

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-10-18T13:55:31Z

+        cy[8] = cy[9] = h * .215f; cy[10] = cy[11] = h * .10f;
+        cx[12] = w * .43f; cx[13] = w * .57f; cy[12] = cy[13] = h * .92f;
+        cx[14] = (side + .025f) * w; cx[15] = (1 - side - .025f) * w;
+        cy[14] = cy[15] = h * .86f;


Keep 720p sticks clear of the button clusters

On a supported 1280×720 landscape display, these equations place the 80px left stick at (192, 619) while the 46px Down button is at (160, 522), only about 103px apart for a combined radius of 126px (the right stick and Cross mirror this). Because hit() scans the buttons before the sticks, touches in each overlapping stick cap are reported as Down/Cross instead of analog input, so part of both rendered sticks is unusable on 720p touch displays; derive the spacing or radii so these circles do not intersect.

Useful? React with 👍 / 👎.

anxiousintrovert added 3 commits October 14, 2026 16:35

Add Android support on the shared Vulkan renderer

c23cd9c

Pin Android renderer changes for Android

262038f

Locate the Kazarov port override script

9b62464

chatgpt-codex-connector Bot reviewed Oct 14, 2026

View reviewed changes

anxiousintrovert mentioned this pull request Oct 16, 2026

Reduce temporary allocations in shadow volume rendering #192

Merged

Address Android setup review and pin corrected shared renderer

7a55b55

anxiousintrovert mentioned this pull request Oct 16, 2026

Add opt-in frame resolution scaling to the shared Vulkan renderer TheMoonPeople/Kazarov#9

Closed

anxiousintrovert added 2 commits October 17, 2026 01:00

Merge upstream Chronicle and preserve compatible Android renderer

e3c8250

Track the compatible Chronicle Android renderer branch

455dd7e

chatgpt-codex-connector Bot reviewed Oct 18, 2026

View reviewed changes

Correct Android font assets and separate touch control hitboxes

6cf6402

Adubbz merged commit 63a0eb5 into TheMoonPeople:master Oct 19, 2026
2 of 6 checks passed

anxiousintrovert mentioned this pull request Oct 19, 2026

Use official Kazarov without requiring the Android compatibility fork #204

Closed

Navigation Menu

Repository navigation

Add Android support for Chronicle - #188

Add Android support for Chronicle#188
Adubbz merged 7 commits into
TheMoonPeople:masterfrom
anxiousintrovert:codex/android-support-pr

anxiousintrovert commented Oct 14, 2026 •

edited

Loading

Uh oh!

chatgpt-codex-connector Bot commented Oct 14, 2026 •

edited

Loading

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

chatgpt-codex-connector Bot Oct 14, 2026

Uh oh!

chatgpt-codex-connector Bot Oct 14, 2026

Uh oh!

chatgpt-codex-connector Bot Oct 14, 2026

Uh oh!

chatgpt-codex-connector Bot Oct 14, 2026

Uh oh!

anxiousintrovert commented Oct 18, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

chatgpt-codex-connector Bot Oct 18, 2026

Uh oh!

chatgpt-codex-connector Bot Oct 18, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		file(COPY ${CMAKE_SOURCE_DIR}/tools/font/DarkCloudCompendium.ttf DESTINATION ${ANDROID_ASSETS}/lang)
		file(COPY ${CMAKE_SOURCE_DIR}/tools/font/DarkCloudCompendiumThin.ttf DESTINATION ${ANDROID_ASSETS}/lang)

Conversation

anxiousintrovert commented Oct 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Review updates

Building

Validation and scope

Dependency compatibility — do not merge yet

Merge conflict resolution (2026-10-17)

Uh oh!

chatgpt-codex-connector Bot commented Oct 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codex Review Summary

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Oct 14, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot Oct 14, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot Oct 14, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot Oct 14, 2026

Choose a reason for hiding this comment

Uh oh!

anxiousintrovert commented Oct 18, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Oct 18, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot Oct 18, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

anxiousintrovert commented Oct 14, 2026 •

edited

Loading

chatgpt-codex-connector Bot commented Oct 14, 2026 •

edited

Loading