two small bugfixes - #6
Merged
Merged
Conversation
previously, shutil.make_archive() would create the archive relative to the script location. This leads to errors if the script is installed in a shared environment where users lack write permission in that directory
the method expects only one argument, not three setting encoding explicitly does not seem to be necessary as pandas.to_csv() in __get_csvs_from_json() already defaults to utf-8
Contributor
|
Thank you for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @NicolasCARPi,
thanks alot for the quick fix for #4
While running the script I came across two minor issues, see commits below.
Note that the first one only manifests if the install directory is read-only.