update gf12/bp_quad rules - #4435
Merged
eder-matheus merged 1 commit intoAug 14, 2026
Merged
Conversation
designs/gf12/bp_quad/rules-base.json updates: | Metric | Old | New | Type | | ------ | --- | --- | ---- | | placeopt__design__instance__area | 1491642 | 1474875 | Tighten | | placeopt__design__instance__count__stdcell | 1425603 | 1399513 | Tighten | | cts__design__instance__count__setup_buffer | 123966 | 121697 | Tighten | | cts__design__instance__count__hold_buffer | 123966 | 121697 | Tighten | | cts__timing__setup__ws | -534.0 | -511.0 | Tighten | | cts__timing__setup__tns | -338000.0 | -170000.0 | Tighten | | globalroute__timing__setup__tns | -1430.0 | -1850.0 | Failing | | globalroute__timing__hold__ws | -117.0 | -100.0 | Tighten | | globalroute__timing__hold__tns | -476.0 | -400.0 | Tighten | | detailedroute__route__wirelength | 26222976 | 25353167 | Tighten | | finish__timing__setup__tns | -1420.0 | -1150.0 | Tighten | | finish__timing__hold__tns | -818.0 | -434.0 | Tighten | | finish__design__instance__area | 1524210 | 1515688 | Tighten | Signed-off-by: João Mai <jmai@precisioninno.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates various physical design and timing thresholds in rules-base.json for the bp_quad design. While most metrics show improvements in area, cell count, and final timing, the setup TNS at the global routing stage has degraded. It is recommended to investigate the global routing stage to mitigate this degradation rather than simply loosening the threshold, as it could indicate sub-optimal routing or lead to convergence issues.
eder-matheus
approved these changes
Aug 14, 2026
eder-matheus
enabled auto-merge
August 14, 2026 18:00
Member
🔍 QoR checkMetrics reflect the PR merge build — i.e. what will land on the target branch. Advisory — results are log-only and do not affect build status. The authoritative QoR gate remains the local rules-file check. Commit 61 design(s) checked — 14 with regression(s), 0 without a comparable baseline.
❌ asap7/riscv32i base — 1 failing metric(s)
❌ asap7/uart base — 1 failing metric(s)
❌ gf180/aes base — 1 failing metric(s)
❌ gf180/aes-hybrid base — 1 failing metric(s)
❌ ihp-sg13g2/jpeg base — 1 failing metric(s)
❌ nangate45/jpeg base — 1 failing metric(s)
❌ nangate45/tinyRocket base — 1 failing metric(s)
❌ sky130hd/chameleon base — 1 failing metric(s)
❌ sky130hd/gcd base — 2 failing metric(s)
❌ sky130hd/jpeg base — 1 failing metric(s)
❌ sky130hd/riscv32i base — 1 failing metric(s)
❌ sky130hs/gcd base — 1 failing metric(s)
❌ sky130hs/ibex base — 1 failing metric(s)
❌ sky130hs/riscv32i base — 1 failing metric(s)
|
eder-matheus
merged commit Aug 14, 2026
bf79f44
into
The-OpenROAD-Project:master
7 of 8 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
designs/gf12/bp_quad/rules-base.json updates: