Port mapdata to 26.1.x#2676
Open
a6tumn wants to merge 8 commits into
Open
Conversation
Author
|
@LightgraycaAT, you had some review comments on Albazavr's attempted port. Perhaps you would like to review this as well? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Summary
I looked into the vanilla map data changes and worked this out as a potential set of fixes to update our own map data. Overall, I think that these changes allow us to copy vanilla behavior more closely and simplify a lot of the extra code we had on top of MapItemSavedData. There may still be some unused methods that would not be required after these changes, but I will leave them for now until this PR gets some reviews.