Skip to content

Port mapdata to 26.1.x#2676

Open
a6tumn wants to merge 8 commits into
TeamTwilight:latestfrom
a6tumn:26.1-fixme-mapdata
Open

Port mapdata to 26.1.x#2676
a6tumn wants to merge 8 commits into
TeamTwilight:latestfrom
a6tumn:26.1-fixme-mapdata

Conversation

@a6tumn

@a6tumn a6tumn commented Jul 23, 2026

Copy link
Copy Markdown

Description

  • Switched to using Codec(s) in the map data classes rather than NBT tags

  • Switced to using MapId to key map data rather than String

  • Moved map state management into a dedicated class rather than having it be part of the map data implementations

  • Split state management helpers into distinct ServerLevel and ClientLevel implementations which more closely aligns with new vanilla behavior

  • Added AT entry for MapItemSavedData#getFrameKey(...) so it can be called in the map data constructors

  • Updated call sites for the map items and network packets to reflect above changes

Summary

I looked into the vanilla map data changes and worked this out as a potential set of fixes to update our own map data. Overall, I think that these changes allow us to copy vanilla behavior more closely and simplify a lot of the extra code we had on top of MapItemSavedData. There may still be some unused methods that would not be required after these changes, but I will leave them for now until this PR gets some reviews.

@a6tumn

a6tumn commented Jul 23, 2026

Copy link
Copy Markdown
Author

@LightgraycaAT, you had some review comments on Albazavr's attempted port. Perhaps you would like to review this as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant