Skip to content

Ported entities to 26.1.x#2640

Open
albazavr-alba wants to merge 12 commits into
TeamTwilight:latestfrom
albazavr-alba:port-entities
Open

Ported entities to 26.1.x#2640
albazavr-alba wants to merge 12 commits into
TeamTwilight:latestfrom
albazavr-alba:port-entities

Conversation

@albazavr-alba

Copy link
Copy Markdown

No description provided.

Comment thread src/main/java/twilightforest/entity/projectile/TFArrow.java

@a6tumn a6tumn left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment

Comment thread src/main/java/twilightforest/entity/projectile/TFArrow.java
Comment thread src/main/java/twilightforest/entity/ProtectionBox.java Outdated

@a6tumn a6tumn left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good to me, see review comment for my remaining question. We should also decide what to do with effects in TFArrow at some point, but don't worry about that.

@albazavr-alba
albazavr-alba requested a review from a6tumn July 20, 2026 17:51
Comment thread src/main/java/twilightforest/entity/ProtectionBox.java Outdated
@albazavr-alba
albazavr-alba requested a review from a6tumn July 20, 2026 20:51
Comment thread src/main/java/twilightforest/entity/passive/Boar.java Outdated
@albazavr-alba
albazavr-alba requested a review from a6tumn July 22, 2026 12:59
Comment thread src/main/java/twilightforest/entity/passive/quest/ram/QuestingRamContext.java Outdated
@albazavr-alba
albazavr-alba requested a review from a6tumn July 23, 2026 14:53
Comment thread src/main/java/twilightforest/entity/projectile/TFArrow.java Outdated

@Tamaized Tamaized left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the one comment, changes look fine

@a6tumn

a6tumn commented Jul 23, 2026

Copy link
Copy Markdown

Thank you for working with us on this. We explored a few options for the effects in TFArrow but ended up deciding to just uncomment the AT entries. These changes look good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants