Skip to content

Ported items to 26.1.x#2638

Open
albazavr-alba wants to merge 11 commits into
TeamTwilight:latestfrom
albazavr-alba:port-items
Open

Ported items to 26.1.x#2638
albazavr-alba wants to merge 11 commits into
TeamTwilight:latestfrom
albazavr-alba:port-items

Conversation

@albazavr-alba

@albazavr-alba albazavr-alba commented Jun 24, 2026

Copy link
Copy Markdown

No description provided.

a6tumn
a6tumn reviewed Jun 24, 2026
View reviewed changes
Comment thread src/main/java/twilightforest/item/travellers_gear/TravellersGearLogic.java Outdated
a6tumn
a6tumn approved these changes Jun 24, 2026
View reviewed changes

@a6tumn a6tumn left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything that stood out to me has been resolved, others should definitely review as well.

LightgraycaAT
LightgraycaAT reviewed Jun 26, 2026
View reviewed changes
Comment thread src/main/java/twilightforest/item/mapdata/TFMagicMapData.java Outdated
@albazavr-alba albazavr-alba mentioned this pull request Jul 4, 2026
Merged
a6tumn
a6tumn reviewed Jul 19, 2026
View reviewed changes
Comment thread src/main/java/twilightforest/item/travellers_gear/TravellersArmorItem.java
@a6tumn

a6tumn commented Jul 19, 2026

Copy link
Copy Markdown

Do also be aware that the traveller's component modifier manager have been refactored and some of the changes may affect files being ported here.

@albazavr-alba
albazavr-alba requested a review from a6tumn July 20, 2026 00:27
a6tumn
a6tumn suggested changes Jul 20, 2026
View reviewed changes

@a6tumn a6tumn left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments still need to be addressed

@albazavr-alba

albazavr-alba commented Jul 20, 2026

Copy link
Copy Markdown
Author

Some comments still need to be addressed

I really don't know how to fix map's data

@a6tumn

a6tumn commented Jul 20, 2026

Copy link
Copy Markdown

Some comments still need to be addressed

I really don't know how to fix map's data

No worries. Are you able to revert the partial implementations and add FIXME comments?

@albazavr-alba

albazavr-alba commented Jul 20, 2026

Copy link
Copy Markdown
Author

Some comments still need to be addressed

I really don't know how to fix map's data

No worries. Are you able to revert the partial implementations and add FIXME comments?

Can I revert them to state before port and add FIXME comments?

@a6tumn

a6tumn commented Jul 20, 2026

Copy link
Copy Markdown

Some comments still need to be addressed

I really don't know how to fix map's data

No worries. Are you able to revert the partial implementations and add FIXME comments?

Can I revert them to state before port and add FIXME comments?

Yes.

@albazavr-alba
albazavr-alba requested a review from a6tumn July 20, 2026 18:13
LightgraycaAT
LightgraycaAT reviewed Jul 22, 2026
View reviewed changes
Comment thread src/main/java/twilightforest/item/MoonDialItem.java Outdated
LightgraycaAT
LightgraycaAT reviewed Jul 22, 2026
View reviewed changes
Comment thread src/main/java/twilightforest/item/MoonDialItem.java Outdated
a6tumn
a6tumn reviewed Jul 22, 2026
View reviewed changes
Comment thread src/main/java/twilightforest/item/MoonDialItem.java Outdated
LightgraycaAT
LightgraycaAT reviewed Jul 22, 2026
View reviewed changes
Comment thread src/main/java/twilightforest/item/MoonDialItem.java Outdated
Tamaized
Tamaized reviewed Jul 23, 2026
View reviewed changes
Comment thread src/main/java/twilightforest/item/MoonDialItem.java Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Tamaized Tamaized Tamaized approved these changes
+2 more reviewers
@LightgraycaAT LightgraycaAT LightgraycaAT left review comments
@a6tumn a6tumn a6tumn approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@albazavr-alba @a6tumn @Tamaized @LightgraycaAT