Skip to content

Fix required CI jobs stuck in pending state for non-code related PRs - #13687

Open
TobiGr wants to merge 2 commits into
TeamNewPipe:devfrom
TobiGr:sonar
Open

Fix required CI jobs stuck in pending state for non-code related PRs#13687
TobiGr wants to merge 2 commits into
TeamNewPipe:devfrom
TobiGr:sonar

Conversation

@TobiGr

@TobiGr TobiGr commented Jul 16, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

What is it?

  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

This PR takes care of the CI.

  • The first commit deletes the sonar job from the PR CI. The job was already disabled because the job was missing a token. I enabled and configured the GitHub app instead which is the recommended config nowadays. SonarQube creates a comment on PRs now once its analysis is completed (see below).
  • The second commit ensures that the required CI jobs succeed early if only ignored files are changed. The jobs were stuck in the pending state previously if only ignored files had been changed. The changes can be seen in my fork:

Due diligence

@TobiGr
TobiGr requested review from Stypox and theimpulson July 16, 2026 07:37
@TobiGr TobiGr added meta Related to the project but not strictly to code code quality Improvements to the codebase to improve the code quality labels Jul 16, 2026
@github-actions github-actions Bot added the size/small PRs with less than 50 changed lines label Jul 16, 2026
@sonarqubecloud

sonarqubecloud Bot commented Jul 16, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@github-actions github-actions Bot added size/medium PRs with less than 250 changed lines and removed size/small PRs with less than 50 changed lines labels Jul 16, 2026
@AudricV AudricV added the CI Everything related to CI (Continuous integration) label Jul 16, 2026
@TobiGr TobiGr changed the title Delete SonarQube job which has been replaced by a GitHub app Fix required CI jobs stuck in pending state for non-code related PRs Jul 16, 2026
theimpulson
theimpulson reviewed Jul 17, 2026
View reviewed changes
Comment thread .github/workflows/ci.yml
only_ignored=true
for file in $CHANGED; do
case "$file" in
README.md | doc/* | fastlane/* | assets/* | .github/*.md | .github/**/*.md | .github/FUNDING.yml | .github/ISSUE_TEMPLATE/*)

@theimpulson theimpulson Jul 17, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe can be nicely formatted into a list or something and put on top so its easy to read and add new files in future?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@theimpulson theimpulson theimpulson left review comments
@Stypox Stypox Awaiting requested review from Stypox

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

CI Everything related to CI (Continuous integration) code quality Improvements to the codebase to improve the code quality meta Related to the project but not strictly to code size/medium PRs with less than 250 changed lines

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@TobiGr @theimpulson @AudricV